Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.3.6 is not PVP compliant #74

Open
tmcgilchrist opened this issue May 27, 2023 · 0 comments
Open

Version 0.3.6 is not PVP compliant #74

tmcgilchrist opened this issue May 27, 2023 · 0 comments

Comments

@tmcgilchrist
Copy link
Contributor

Version 0.3.6 is not PVP compliant.
See the diff here liyang/thyme@0.3.5.4...master.

For example the signature of mkUTCTime has changed from mkUTCTime :: Day -> DiffTime -> UTCTime to mkUTCTime :: Year -> Month -> DayOfMonth -> Hour -> Minute -> Double -> UTCTime. The API has expanded as well.

I would suggest releasing a 0.4 version to hackage (based on the changes on master) and blacklisting the 0.3.6 version. Additionally we should create a 0.3.7 that just updates package version bounds without any code changes.

[1] https://hackage.haskell.org/package/thyme-0.3.6/docs/Data-Thyme-Clock.html#v:mkUTCTime
[2] https://hackage.haskell.org/package/thyme-0.3.5.5/docs/Data-Thyme-Time-Core.html#v:mkUTCTime

I uploaded thyme-0.4 and deprecated 0.3.6
@fumieval

A compliant working version of the 0.3 series of releases would be useful to existing users of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant