Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible reversion of W.splitFileName "/\\?/a:" #219

Closed
joeyh opened this issue Jan 9, 2024 · 5 comments · Fixed by #220
Closed

possible reversion of W.splitFileName "/\\?/a:" #219

joeyh opened this issue Jan 9, 2024 · 5 comments · Fixed by #220

Comments

@joeyh
Copy link

joeyh commented Jan 9, 2024

Before 1.4.100.2, System.FilePath.Windows.splitFileName "/\\?/a:" == ("/\\?/a:","") and in that version and since it changed to ("/\\?/","a:")

I don't fully understand Windows path semantics, and this path was generated by QuickCheck, so I don't know which is right, but 1.4.100.2 did not document any change besides optimizations. Which makes me suspect this is an unintentional change.

Also, 6a1c98d fixed a reversion in W.splitFileName "\\\\?\\A:\\fred" which seems very similar to this.

ghci> System.FilePath.Windows.splitFileName "\\\\?\\A:\\fred"
("\\\\?\\A:\\","fred")
ghci> System.FilePath.Windows.splitFileName "\\\\?\\A:\\"
("\\\\?\\A:\\","")
ghci> System.FilePath.Windows.splitFileName "\\\\?\\A:"
("\\\\?\\","A:")
@Bodigrim
Copy link
Contributor

Bodigrim commented Jan 9, 2024

I can take a look over the next weekend.

@hasufell
Copy link
Member

@joeyh
Copy link
Author

joeyh commented Jan 18, 2024

This same issue is discussed here #183 (comment)

@hasufell
Copy link
Member

Do you have a proposed fix?

@Bodigrim
Copy link
Contributor

I'm working on this, hopefully will finish tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants