Skip to content

Commit 03e7986

Browse files
committed
Merge branch 'issue-1216'
2 parents d94ce2a + c25a067 commit 03e7986

File tree

2 files changed

+12
-17
lines changed

2 files changed

+12
-17
lines changed

ghcup.cabal

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,14 @@ flag yaml-streamly
8282
default: False
8383
manual: True
8484

85+
common common-ghc-options
86+
ghc-options:
87+
-Wall -fwarn-tabs -fwarn-incomplete-uni-patterns
88+
-fwarn-incomplete-record-updates -Werror=incomplete-patterns
89+
8590
common app-common-depends
91+
import: common-ghc-options
92+
8693
build-depends:
8794
, aeson >=1.4
8895
, aeson-pretty ^>=0.8.8
@@ -197,10 +204,6 @@ library
197204
TypeFamilies
198205
ViewPatterns
199206

200-
ghc-options:
201-
-Wall -fwarn-tabs -fwarn-incomplete-uni-patterns
202-
-fwarn-incomplete-record-updates
203-
204207
build-depends:
205208
, aeson >=1.4
206209
, async >=0.8 && <2.3
@@ -350,10 +353,6 @@ library ghcup-optparse
350353
StrictData
351354
TupleSections
352355

353-
ghc-options:
354-
-Wall -fwarn-tabs -fwarn-incomplete-uni-patterns
355-
-fwarn-incomplete-record-updates
356-
357356
build-depends: ghcup
358357

359358
if flag(internal-downloader)
@@ -399,10 +398,6 @@ library ghcup-tui
399398
StrictData
400399
TupleSections
401400

402-
ghc-options:
403-
-Wall -fwarn-tabs -fwarn-incomplete-uni-patterns
404-
-fwarn-incomplete-record-updates
405-
406401
build-depends:
407402
, ghcup
408403
, brick >=2.1 && <2.8
@@ -434,8 +429,7 @@ executable ghcup
434429
TupleSections
435430

436431
ghc-options:
437-
-Wall -fwarn-tabs -fwarn-incomplete-uni-patterns
438-
-fwarn-incomplete-record-updates -threaded
432+
-threaded
439433

440434
build-depends:
441435
, ghcup
@@ -459,6 +453,7 @@ executable ghcup
459453
buildable: False
460454

461455
test-suite ghcup-test
456+
import: common-ghc-options
462457
type: exitcode-stdio-1.0
463458
main-is: Main.hs
464459
build-tool-depends: hspec-discover:hspec-discover -any
@@ -481,8 +476,7 @@ test-suite ghcup-test
481476
TupleSections
482477

483478
ghc-options:
484-
-Wall -fwarn-tabs -fwarn-incomplete-uni-patterns
485-
-fwarn-incomplete-record-updates -fconstraint-solver-iterations=0
479+
-fconstraint-solver-iterations=0
486480

487481
build-depends:
488482
, base >=4.12 && <5
@@ -510,6 +504,7 @@ test-suite ghcup-test
510504
build-depends: unix ^>=2.7 || ^>=2.8
511505

512506
test-suite ghcup-optparse-test
507+
import: common-ghc-options
513508
type: exitcode-stdio-1.0
514509
hs-source-dirs: test/optparse-test
515510
main-is: Main.hs
@@ -533,7 +528,6 @@ test-suite ghcup-optparse-test
533528
cpp-options: -DIS_WINDOWS
534529

535530
default-language: Haskell2010
536-
ghc-options: -Wall
537531
build-depends:
538532
, base
539533
, ghcup

lib-tui/GHCup/Brick/Actions.hs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -468,6 +468,7 @@ changelog' (_, ListResult {..}) = do
468468
Darwin -> exec "open" [T.unpack $ decUTF8Safe $ serializeURIRef' uri] Nothing Nothing
469469
Linux _ -> exec "xdg-open" [T.unpack $ decUTF8Safe $ serializeURIRef' uri] Nothing Nothing
470470
FreeBSD -> exec "xdg-open" [T.unpack $ decUTF8Safe $ serializeURIRef' uri] Nothing Nothing
471+
OpenBSD -> exec "xdg-open" [T.unpack $ decUTF8Safe $ serializeURIRef' uri] Nothing Nothing
471472
Windows -> do
472473
let args = "start \"\" " ++ (T.unpack $ decUTF8Safe $ serializeURIRef' uri)
473474
c <- liftIO $ system $ args

0 commit comments

Comments
 (0)