Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from calling cabal on file targets #427

Closed
TeofilC opened this issue Feb 2, 2024 · 3 comments
Closed

Migrate away from calling cabal on file targets #427

TeofilC opened this issue Feb 2, 2024 · 3 comments

Comments

@TeofilC
Copy link

TeofilC commented Feb 2, 2024

In haskell/cabal#8966 cabal removed its support for file and module targets.
But these are currently used by hie-bios to determine the flags for components.
Perhaps we should just be calling cabal repl on the component instead?

See also the cabal issue: haskell/cabal#9688

@mpickering
Copy link
Collaborator

I think that the patch in cabal should be reverted. This has been how hie-bios has interacted with cabal-install since the start of the library and it has been a stable and robust interface.

If this feature is removed then there should be a long deprecation period to avoid breaking HLS users who have old version of hie-bios and a suitable migration implemented in hie-bios.

@fendor
Copy link
Collaborator

fendor commented Feb 2, 2024

This cabal PR slipped past me, otherwise I would have voiced this concern much sooner. Thanks for catching this before the next cabal release!

@TeofilC
Copy link
Author

TeofilC commented Feb 5, 2024

I'll close this for now since it looks like the cabal PR is getting reverted

@TeofilC TeofilC closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants