Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: All UI looks pixelated when screen scale 125% #183

Open
2 of 4 tasks
IsaacInsoll opened this issue Oct 17, 2024 · 4 comments
Open
2 of 4 tasks

Bug: All UI looks pixelated when screen scale 125% #183

IsaacInsoll opened this issue Oct 17, 2024 · 4 comments
Labels
bug Something isn't working fixed in beta fix for this issue/request is already present in one of the beta versions
Milestone

Comments

@IsaacInsoll
Copy link

This app works great, thank you so much to everyone involved!

I've been running 125% display scaling for about 1000 years now and every app has looked beautiful (IE: correctly rendering) for years so the fact that HASS.Agent doesn't really stands out. This isn't about changing resolutions or settings or anything, just the default look of everything on a clean install on a PC running 125% scaling looks really bad.

The software isn't unusable, but it's very noticable.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Set Windows display scaling to 125%
    image
  2. Compare rendering of the app to everything else running on your system
    Here is a screenshot of Chrome running the dashboard beside the HASS.Agent 'right click' browser window:
    image
    Here is a screenshot of the main window with this github issue beside
    image

Expected behavior
App render "properly" not in what appears to be a lower resolution version scaled up.

Misc info (please complete the following information):
image

  • HASS.Agent version: 2.1.0

Please check what's applicable (multiple answers possible):

  • Installed via installer
  • Installed manually
  • Problem occurs in HASS.Agent
  • Problem occurs in Satellite Service
@IsaacInsoll IsaacInsoll added the bug Something isn't working label Oct 17, 2024
@IsaacInsoll IsaacInsoll changed the title Bug: Bug: All UI looks pixelated when screen scale 125% Oct 18, 2024
@amadeo-alex
Copy link
Collaborator

Oh the joys of winforms :D
Scalability of windows apps is as complicated topic as the one of modern device sleep modes.

Most of HASS.Agent UI and the 3rd party framework used for the styling was done and chosen by the original project so I can't tell for certain if this is easily fixable.
With the rewrite of "v3" the UI will be done in WinUI3 so this shouldn't be an issue, this however doesn't solve your issue.

While I could argue that the config windows of HASS.Agent are not seen that often, the webview is and you're right, it looks off.
I'll try my best to find a fix/workaround, if not for the whole app the maybe at least for the webview.

@IsaacInsoll
Copy link
Author

Thanks so much,

I was logging this as a I don't know if you are aware of this problem and it could be an easy fix, but I love the software and I'm using it anyway so it's ugly but perfectly functional and does everything I need it to do so if it's too hard then don't worry about it.

I'm a JS/PHP/android/iOS dev so windows is basically the only one I can't help with 😐

@amadeo-alex
Copy link
Collaborator

Could you please try this test build? https://github.com/amadeo-alex/HASS.Agent/releases/tag/2.1.1-beta2-dpiaware
I tried 125%/150% on one monitor, looks ok I think and visibly re-scales when moving to 100% monitor.
Note: version will still say 2.1.0

@IsaacInsoll
Copy link
Author

Hi,
That has worked perfectly.
Pictured: top row is previous "google chrome vs HASS.Agent" and bottom is "google chrome vs HASS.Agent dpiaware"
As you can see it looks perfect 🔥
(it may be getting compressed by github upload or something but 'in person' it's fantastic)

image

My testing was purely "i've always run 125% scaling on a 4k monitor with a single screen" so I haven't tested multi screens or changing resolutions but it looks awesome!

Thank you so much, I'm just going to run this build until there is another release <3

amadeo-alex added a commit that referenced this issue Oct 19, 2024
…187)

This PR fixes HASS.Agent UI looking blurry on devices where scaling is set to values other than 100%
Thanks to @IsaacInsoll for reporting! #183
@amadeo-alex amadeo-alex added the fixed in beta fix for this issue/request is already present in one of the beta versions label Oct 26, 2024
@amadeo-alex amadeo-alex added this to the 2.1.1 milestone Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in beta fix for this issue/request is already present in one of the beta versions
Projects
None yet
Development

No branches or pull requests

2 participants