PROPOSAL: All Localization Exception Should Carry Over The Exception Data

[cjdutoit]

I would like to propose a change for how we localize external exceptions in our foundation services by considering the data collection in the localization process.

We currently do:

    public class StudentDependencyValidationException : Xeption
    {
        public StudentDependencyValidationException(Exception innerException)
            : base(
                  message: $"Student dependency validation error occurred, please try again.", 
                  innerException, 
                  data: innerException.Data){ }
    }

I propose that we do

    public class StudentDependencyValidationException : Xeption
    {
        public StudentDependencyValidationException(Exception innerException)
            : base(
                  message: $"Student dependency validation error occurred, please try again.", 
                  innerException, 
                  data: innerException.Data){ }
    }

Reason for proposal
Because we wrap the external exception with our local exception we loose access to the data dictionary of the external exception as this now sits one level down. When we unwrap / wrap exceptions higher up i.e. in orchestrations, we will see the localised exception with an empty data dictionary. But if we make the exception data of the localised exception equal to the data of the external exception, then we can will be able to transcend the error details of the external exception in the same way we do between the API and UI.

This will be very useful when we use external libraries that are The Standard compliant.