From 4a416a25ac54436a17d3c54948d5f1efff1339c7 Mon Sep 17 00:00:00 2001 From: Tristen Harr Date: Thu, 6 Jun 2024 23:07:02 -0500 Subject: [PATCH] fix order_by case sensitivity --- CHANGELOG.md | 3 +++ connector-definition/connector-metadata.yaml | 4 ++-- package-lock.json | 4 ++-- package.json | 2 +- src/handlers/query.ts | 2 +- 5 files changed, 9 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a54eec8..c3a712d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,9 @@ # DuckDB Connector Changelog This changelog documents changes between release tags. +## [0.0.16] - 2024-05-6 +* Change orderBy to use default casing. (Ordering is case-sensitive and uses underlying implementation which differs from Postgres) + ## [0.0.15] - 2024-05-6 * Remove linux/arm/v7 from platforms diff --git a/connector-definition/connector-metadata.yaml b/connector-definition/connector-metadata.yaml index c312891..14c43fa 100644 --- a/connector-definition/connector-metadata.yaml +++ b/connector-definition/connector-metadata.yaml @@ -1,13 +1,13 @@ packagingDefinition: type: PrebuiltDockerImage - dockerImage: ghcr.io/hasura/ndc-duckdb:v0.0.15 + dockerImage: ghcr.io/hasura/ndc-duckdb:v0.0.16 supportedEnvironmentVariables: - name: DUCKDB_URL description: The url for the DuckDB database commands: update: type: Dockerized - dockerImage: ghcr.io/hasura/ndc-duckdb:v0.0.15 + dockerImage: ghcr.io/hasura/ndc-duckdb:v0.0.16 commandArgs: - update dockerComposeWatch: diff --git a/package-lock.json b/package-lock.json index 5934c58..8f1e9a1 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "duckdb-sdk", - "version": "0.0.15", + "version": "0.0.16", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "duckdb-sdk", - "version": "0.0.15", + "version": "0.0.16", "dependencies": { "@hasura/ndc-sdk-typescript": "^4.5.0", "duckdb": "^1.0.0", diff --git a/package.json b/package.json index c4e6754..800a511 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "duckdb-sdk", - "version": "0.0.15", + "version": "0.0.16", "description": "", "main": "index.js", "scripts": { diff --git a/src/handlers/query.ts b/src/handlers/query.ts index 08f7885..e0f400f 100644 --- a/src/handlers/query.ts +++ b/src/handlers/query.ts @@ -328,7 +328,7 @@ function build_query( currentAlias = nextAlias; } order_elems.push( - `LOWER(${escape_double(currentAlias)}.${escape_double(elem.target.name)}) ${elem.order_direction}` + `${escape_double(currentAlias)}.${escape_double(elem.target.name)} ${elem.order_direction}` ); } break;