From 037db0856512a0c1dd4dff3ad411b6f3a41cd4a0 Mon Sep 17 00:00:00 2001
From: Fabian Steeg <steeg@hbz-nrw.de>
Date: Thu, 25 Jan 2024 11:41:49 +0100
Subject: [PATCH] Display label for `@optional` subfields in details view
 (#636)

---
 app/views/tags/result_doc.scala.html | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/app/views/tags/result_doc.scala.html b/app/views/tags/result_doc.scala.html
index 7efe6ca..3be13e8 100644
--- a/app/views/tags/result_doc.scala.html
+++ b/app/views/tags/result_doc.scala.html
@@ -18,6 +18,7 @@
 
 @optional(label: String, key: String, v: JsValue) = {
   @defining((v\key).asOpt[Seq[JsValue]].getOrElse(Seq(v\key))) { elems =>
+    @if(!elems.isEmpty && elems.head.asOpt[String].isDefined) { @label }
     @for(elem <- elems; elemString <- elem.asOpt[String]) {
       @(elemString)@if(elem!=elems.last){ | } else {<br/>}
     }
@@ -45,10 +46,10 @@
           @start.asOpt[String].getOrElse(end.asOpt[String].getOrElse(""))
         }
         <br/>
-        @optional("Erscheinungsort", "location", pub)
-        @optional("Verlag", "publishedBy", pub)
+        @optional("", "location", pub)
+        @optional("", "publishedBy", pub)
         @((pub\"frequency").asOpt[Seq[JsValue]].map { freq =>
-          optional("Erscheinungsweise", "label", freq.head)
+          optional("", "label", freq.head)
         })
       </td>
     </tr>
@@ -225,8 +226,8 @@
           } else {
             @optional("", "note", related)
           }
-          @optional("", "isbn", related)
-          @optional("", "issn", related)
+          @optional("ISBN: ", "isbn", related)
+          @optional("ISSN: ", "issn", related)
         </td>
     </tr>
   }