Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When press Select All(Filtered) button, the previously selected value is deselected. #567

Open
jung0han opened this issue Mar 12, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@jung0han
Copy link

jung0han commented Mar 12, 2022

Describe the bug
When using the Custom Filter option, search for keywords, and press Select All(Filtered) button, the previously selected value is deselected.

https://react-multi-select-component.pages.dev/iframe?id=custom-filter--example-custom-filter&args=&viewMode=story

To Reproduce
Steps to reproduce the behavior:

  1. Select any value.
  2. Search by specific keyword.
  3. Click Select All (Filtered).
  4. The previously selected value is deselected and only the filtered value is selected.

Expected behavior
The previously selected value remains and the filtered value is added.

Screenshoot
Hnet-image

@jung0han jung0han added the bug Something isn't working label Mar 12, 2022
@harshzalavadiya
Copy link
Member

Thanks I'll take a look

@MegaKeegMan
Copy link
Contributor

@jung0han Are you sure that it is actually being de-selected or does it just look that way. Since "R5-D4" appears later in the list, I suspect that it is just not showing up in list of selected items, and the json there is being cut-off. I would like to see what happens when you type "R5-D4" in the search. I suspect it will be there and checked.

@jung0han
Copy link
Author

jung0han commented Jun 8, 2022

@jung0han Are you sure that it is actually being de-selected or does it just look that way. Since "R5-D4" appears later in the list, I suspect that it is just not showing up in list of selected items, and the json there is being cut-off. I would like to see what happens when you type "R5-D4" in the search. I suspect it will be there and checked.

@MegaKeegMan Unfortunately when I search for "R5-D4" again, it's deselected.

@koshpendi
Copy link

@MegaKeegMan already fixed? i can commit if not

@MegaKeegMan
Copy link
Contributor

@koshpendi thanks and go ahead. I realize I had actually misread this issue back when I commented and can easily reproduce this bug. I have not written any fix.

@Shorifpatwary
Copy link

Shorifpatwary commented Dec 28, 2022

can't fin this problem in this example. code sandbox example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants