Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flat uniform icons might be invisible #11

Open
hdlx opened this issue Aug 22, 2024 · 5 comments
Open

Flat uniform icons might be invisible #11

hdlx opened this issue Aug 22, 2024 · 5 comments

Comments

@hdlx
Copy link
Owner

hdlx commented Aug 22, 2024

Win 10 setting icon for example, is white and uniform. On light theme, it is invisible. We could detect this situation and apply an effect.

@hdlx hdlx changed the title Flat design icons might be invisible Flat uniform icons might be invisible Aug 22, 2024
@mcrampon
Copy link

Spotify icon is now white:

image

Perhaps this doesn't necessarily need to happen to all colors?

@hdlx
Copy link
Owner Author

hdlx commented Aug 28, 2024

Hey 🙂 I'm not sure to understand. Some apps switch icons depending on windows theme color, thus handling properly monochrome icons already. It seems to be the case with in your screenshot. In this case, the feature of this ticket would compare the icon with the background, and do nothing since the icon is already visible.

Or, you mean that Spotify icon changed following macappswitcher update? If so, this is not related to this ticket (it has no been implemented yet). However, the UWP icon code used to be inconsistent with taskbar. In a recent update, I tried to improve this. If the icon matches with the taskbar, it's the expected behavior, and the previous one was incorrect. If it doesn't match, I'll try to reproduce the issue 🙂

@mcrampon
Copy link

Or, you mean that Spotify icon changed following macappswitcher update?

Yep. Used to be green, now is white.

If so, this is not related to this ticket (it has no been implemented yet). However, the UWP icon code used to be inconsistent with taskbar. In a recent update, I tried to improve this. If the icon matches with the taskbar, it's the expected behavior, and the previous one was incorrect. If it doesn't match, I'll try to reproduce the issue 🙂

Yeah, it's green in the taskbar :)

@hdlx
Copy link
Owner Author

hdlx commented Aug 29, 2024

Updated icon logic in the latest release, it should fix the issue you had with Spotify 🙂

@mcrampon
Copy link

Updated icon logic in the latest release, it should fix the issue you had with Spotify 🙂

Works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants