Merge pull request #492 from kinvolk/plugin-improvements

Plugin improvements

Author: illume

Makefile

@@ -72,7 +72,8 @@ frontend-test:
 	cd frontend && npm run test -- --coverage
 
 plugins-test:
-	cd plugins/headlamp-plugin && npm install && ./test-headlamp-plugin.sh
+	cd plugins/headlamp-plugin && npm install && ./test-headlamp-plugin.sh 
+	cd plugins/headlamp-plugin && ./test-plugins-examples.sh
 
 image:
 	$(DOCKER_CMD) build \

plugins/examples/pod-counter/package.json

@@ -9,7 +9,7 @@
     "build": "headlamp-plugin build",
     "format": "headlamp-plugin format",
     "lint": "headlamp-plugin lint",
-    "tsc": "tsc"
+    "tsc": "tsc --noEmit"
   },
   "keywords": [
     "headlamp",

plugins/examples/sidebar/package.json

@@ -1,14 +1,14 @@
 {
   "name": "sidebar",
   "version": "0.0.1",
-  "description": "Your Headlamp plugin",
+  "description": "Example plugin showing how to add a sidebar menu item.",
   "scripts": {
     "start": "headlamp-plugin start",
     "build": "headlamp-plugin build",
     "format": "headlamp-plugin format",
     "lint": "headlamp-plugin lint",
     "lint-fix": "headlamp-plugin lint --fix",
-    "tsc": "tsc"
+    "tsc": "tsc --noEmit"
   },
   "keywords": [
     "headlamp",

plugins/headlamp-plugin/bin/headlamp-plugin.js

@@ -324,11 +324,14 @@ function format(packageFolder) {
 function lint(packageFolder, fix) {
   try {
     const extra = fix ? ' --fix' : '';
-    child_process.execSync('eslint -c package.json --ext .js,.ts,.tsx src/' + extra, {
-      stdio: 'inherit',
-      cwd: packageFolder,
-      encoding: 'utf8',
-    });
+    child_process.execSync(
+      'eslint -c package.json --max-warnings 0 --ext .js,.ts,.tsx src/' + extra,
+      {
+        stdio: 'inherit',
+        cwd: packageFolder,
+        encoding: 'utf8',
+      }
+    );
   } catch (e) {
     console.error(`Problem running eslint inside of "${packageFolder}"`);
     return 1;

plugins/headlamp-plugin/config/webpack.config.js

@@ -46,6 +46,10 @@ module.exports = {
   },
   module: {
     rules: [
+      {
+        test: /\.css$/i,
+        use: ['style-loader', 'css-loader'],
+      },
       {
         test: /\.(js|jsx|ts|tsx)$/,
         exclude: /node_modules/,
@@ -68,12 +72,9 @@ module.exports = {
           {
             loader: require.resolve('url-loader'),
             options: {
-              limit: false,
+              limit: 9999999999999,
             },
           },
-          {
-            loader: require.resolve('file-loader'),
-          },
         ],
       },
     ],