Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters of returned best expressions are not necessarily set correctly #2

Open
gkronber opened this issue Apr 22, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@gkronber
Copy link
Member

No description provided.

@gkronber gkronber added the bug Something isn't working label Apr 22, 2023
gkronber added a commit that referenced this issue Apr 23, 2023
…ake sure that only those states can be returned as best states. These also have all their parameters set correctly.
gkronber added a commit that referenced this issue Apr 23, 2023
… of terminal states (and does not use caching) and MSE is used for heuristics (and caches values). This makes sure that the best expressions returned by the algorithm are certain to have their parameters optimized.
@gkronber
Copy link
Member Author

gkronber commented Apr 23, 2023

ff40e81 separates the calculation of MSE (for heuristics) and the calculation of MDL (for model selection) but is not an ideal solution.

The main problem here is that two expressions that might be semantically equivalent and therefore have the same error can have different MDL values. Returning a cached MDL value for expressions with the same semanic hash would therefore be incorrect, while returning cached MSE values is fine.

Actually, the same issue concerns the de-duplication of search states (semantically equivalent states may have different MDL). However, this is not a problem as long as states are visited in order of their length (as in breadth-first and beam search).

The best solution would probably be to store the MDL of the shortest expression (assuming that a shorter expression probably has a better MDL).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant