Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use plottly for rendering of graphs #2

Open
JonasCir opened this issue Jan 25, 2021 · 4 comments
Open

Use plottly for rendering of graphs #2

JonasCir opened this issue Jan 25, 2021 · 4 comments
Assignees

Comments

@JonasCir
Copy link
Member

I used plottly.js in the past and its super simple to use and gives beautiful, interactive graphs.

@JonasCir JonasCir self-assigned this Jan 25, 2021
@DavidBaldsiefen
Copy link
Member

If it's easier to use, go ahead :) But please don't do large changes to DataFetcher.js (yet), as I want to clean it up a little

@JonasCir
Copy link
Member Author

Yeah it's pretty simple, if you clean up, please split the part which fetches data and the part which renders the data. by this it's easier to introduce it. Sure I'll wait some time...

@DavidBaldsiefen
Copy link
Member

Yeah it's pretty simple, if you clean up, please split the part which fetches data and the part which renders the data. by this it's easier to introduce it. Sure I'll wait some time...

It's already split up, in theindex.htmlis a drawResults(timings) function which is called whenever all the data is fetched. Timings is an array containing each time in Minutes. If the value smoothness is > 1, this array already containes the smoothed values. In theory I would prefer to have all the JavaScript code outside of the index.html but that's just a pet-peeve of mine ;)

@DavidBaldsiefen
Copy link
Member

Now that I think about it, I might actually change the array which is returned to contain more infos, such das dates and links to the relevant jobs. But for now, just assume timings contains times like this: [12.43, 14.32, 10.0]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants