From a7f5d188cc7a23b1946d48693ada22fe90d9ffe0 Mon Sep 17 00:00:00 2001 From: Vasil Dimov Date: Tue, 23 Jul 2024 11:44:40 +0200 Subject: [PATCH 1/2] doc: add release notes for #22729 --- doc/release-notes-22729.md | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 doc/release-notes-22729.md diff --git a/doc/release-notes-22729.md b/doc/release-notes-22729.md new file mode 100644 index 0000000000000..7b836c2701a4a --- /dev/null +++ b/doc/release-notes-22729.md @@ -0,0 +1,21 @@ +Notable changes +=============== + +P2P and network changes +----------------------- + +- Previously if Bitcoin Core was listening for P2P connections, either using + default settings or via `bind=addr:port` it would always also bind to + `127.0.0.1:8334` to listen for Tor connections. It was not possible to switch + this off, even if the node didn't use Tor. This has been changed and now + `bind=addr:port` results in binding on `addr:port` only. The default behavior + of binding to `0.0.0.0:8333` and `127.0.0.1:8334` has not been changed. + + If you are using a `bind=...` configuration without `bind=...=onion` and rely + on the previous implied behavior to accept incoming Tor connections at + `127.0.0.1:8334`, you need to now make this explicit by using + `bind=... bind=127.0.0.1:8334=onion`. (#22729) + +- Bitcoin Core will now fail to start up if any of its P2P binds fail, rather + than the previous behaviour where it would only abort startup if all P2P + binds had failed. (#22729) From 6d33e13bd493ca6cee7b52b990e4822a28e35d0a Mon Sep 17 00:00:00 2001 From: David Gumberg Date: Fri, 2 Aug 2024 09:45:16 +0200 Subject: [PATCH 2/2] doc: tor.md: use -bind=127.0.0.1:8334=onion for the Tor bind After https://github.com/bitcoin/bitcoin/pull/22729 if `-bind=127.0.0.1` is used, then bitcoind will not automatically also bind on `127.0.0.1:8334`. --- doc/tor.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/tor.md b/doc/tor.md index 65aa3ece02eb3..9560dc29eb985 100644 --- a/doc/tor.md +++ b/doc/tor.md @@ -193,7 +193,7 @@ In a typical situation, where you're only reachable via Tor, this should suffice listen on all devices and another node could establish a clearnet connection, when knowing your address. To mitigate this, additionally bind the address of your Tor proxy: - ./bitcoind ... -bind=127.0.0.1 + ./bitcoind ... -bind=127.0.0.1:8334=onion If you don't care too much about hiding your node, and want to be reachable on IPv4 as well, use `discover` instead: