Missing handling for OBJCXXFLAGS ?

[fanquake]

We have code for deplicating/handling CMAKE_C_FLAGS/CMAKE_CXX_FLAGS/CMAKE_EXE_LINKER_FLAGS, but I can't see it for OBJCXXFLAGS? Is this not needed, or just missing?

Note that on master we also have OBJCXXFLAGS="$CXXFLAGS -Wno-deprecated-declarations" for silencing deprecations (in our own code), but don't see the equivalent in CMake?

[hebasto]

We have code for deplicating/handling CMAKE_C_FLAGS/CMAKE_CXX_FLAGS/CMAKE_EXE_LINKER_FLAGS, but I can't see it for OBJCXXFLAGS? Is this not needed, or just missing?

The current depends/toolchain.cmake.in assumes that Objective C++ flags coincide with C++ flags:

bitcoin/depends/toolchain.cmake.in

Lines 59 to 70 in d58a3c0

	if(NOT DEFINED CMAKE_CXX_FLAGS_INIT)
	set(CMAKE_CXX_FLAGS_INIT "@CXXFLAGS@")
	set(CMAKE_OBJCXX_FLAGS_INIT "@CXXFLAGS@")
	endif()
	if(NOT DEFINED CMAKE_CXX_FLAGS_RELWITHDEBINFO_INIT)
	set(CMAKE_CXX_FLAGS_RELWITHDEBINFO_INIT "@CXXFLAGS_RELEASE@")
	set(CMAKE_OBJCXX_FLAGS_RELWITHDEBINFO_INIT "@CXXFLAGS_RELEASE@")
	endif()
	if(NOT DEFINED CMAKE_CXX_FLAGS_DEBUG_INIT)
	set(CMAKE_CXX_FLAGS_DEBUG_INIT "@CXXFLAGS_DEBUG@")
	set(CMAKE_OBJCXX_FLAGS_DEBUG_INIT "@CXXFLAGS_DEBUG@")
	endif()

EDIT: Removed the wrong statement.

[fanquake]

No silencing deprecation is required because the Qt dependency libraries are included as system ones using the -isystem flag.

Not sure what you mean. It's our code using the deprecated functions, not Qt.

[hebasto]

Note that on master we also have OBJCXXFLAGS="$CXXFLAGS -Wno-deprecated-declarations" for silencing deprecations (in our own code), but don't see the equivalent in CMake?

bitcoin/src/qt/CMakeLists.txt

Lines 124 to 127 in d58a3c0

	set_property(SOURCE macnotificationhandler.mm
	# Ignore warnings "'NSUserNotificationCenter' is deprecated: first deprecated in macOS 11.0".
	APPEND PROPERTY COMPILE_OPTIONS -Wno-deprecated-declarations
	)

No silencing deprecation is required because the Qt dependency libraries are included as system ones using the -isystem flag.

Not sure what you mean. It's our code using the deprecated functions, not Qt.

You're right. Please ignore my wrong statement in the previous #260 (comment).

[fanquake]

Also, is OBJC_OLD_DISPATCH_PROTOTYPES missing, or just missing from the configure output?

[hebasto]

Also, is OBJC_OLD_DISPATCH_PROTOTYPES missing, or just missing from the configure output?

Fixed in #265.

[fanquake]

I think this is fixed now.