Skip to content

Commit fddcee9

Browse files
authored
Merge pull request #221 from VisLab/change-names
Minor cleanup and change of bids/validator class names back
2 parents 14ef334 + 934761c commit fddcee9

File tree

11 files changed

+24
-627
lines changed

11 files changed

+24
-627
lines changed

bids/index.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import { BidsJsonFile, BidsSidecar } from './types/json'
44
import { BidsEventFile, BidsTabularFile, BidsTsvFile } from './types/tsv'
55
import BidsDataset from './types/dataset'
66
import { BidsHedIssue, BidsIssue } from './types/issues'
7-
import SidecarValidator from './validator/sidecarValidator'
8-
import TsvValidator from './validator/tsvValidator'
7+
import BidsHedSidecarValidator from './validator/sidecarValidator'
8+
import BidsHedTsvValidator from './validator/tsvValidator'
99

1010
export {
1111
BidsDataset,
@@ -16,8 +16,8 @@ export {
1616
BidsSidecar,
1717
BidsIssue,
1818
BidsHedIssue,
19-
SidecarValidator,
20-
TsvValidator,
19+
BidsHedSidecarValidator,
20+
BidsHedTsvValidator,
2121
buildBidsSchemas,
2222
validateBidsDataset,
2323
}
@@ -31,8 +31,8 @@ export default {
3131
BidsSidecar,
3232
BidsIssue,
3333
BidsHedIssue,
34-
BidsHedSidecarValidator: SidecarValidator,
35-
BidsHedTsvValidator: TsvValidator,
34+
BidsHedSidecarValidator: BidsHedSidecarValidator,
35+
BidsHedTsvValidator: BidsHedTsvValidator,
3636
buildBidsSchemas,
3737
validateBidsDataset,
3838
}

bids/types/json.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { sidecarValueHasHed } from '../utils'
44
import { parseHedString } from '../../parser/parser'
55
import ParsedHedString from '../../parser/parsedHedString'
66
import { BidsFile } from './basic'
7-
import SidecarValidator from '../validator/sidecarValidator'
7+
import BidsHedSidecarValidator from '../validator/sidecarValidator'
88
import { IssueError } from '../../common/issues/issues'
99

1010
const ILLEGAL_SIDECAR_KEYS = new Set(['hed', 'n/a'])
@@ -20,7 +20,7 @@ export class BidsJsonFile extends BidsFile {
2020
jsonData
2121

2222
constructor(name, jsonData, file) {
23-
super(name, file, SidecarValidator)
23+
super(name, file, BidsHedSidecarValidator)
2424
this.jsonData = jsonData
2525
}
2626
}

bids/types/tsv.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { BidsFile } from './basic'
44
import { convertParsedTSVData, parseTSV } from '../tsvParser'
55
import { BidsSidecar } from './json'
66
import ParsedHedString from '../../parser/parsedHedString'
7-
import TsvValidator from '../validator/tsvValidator'
7+
import BidsHedTsvValidator from '../validator/tsvValidator'
88
import { IssueError } from '../../common/issues/issues'
99

1010
/**
@@ -49,7 +49,7 @@ export class BidsTsvFile extends BidsFile {
4949
* @param {object} mergedDictionary The merged sidecar data.
5050
*/
5151
constructor(name, tsvData, file, potentialSidecars = [], mergedDictionary = {}) {
52-
super(name, file, TsvValidator)
52+
super(name, file, BidsHedTsvValidator)
5353

5454
if (typeof tsvData === 'string') {
5555
this.parsedTsv = parseTSV(tsvData)

bids/validator/sidecarValidator.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { generateIssue, IssueError } from '../../common/issues/issues'
77
/**
88
* Validator for HED data in BIDS JSON sidecars.
99
*/
10-
export class SidecarValidator {
10+
export class BidsHedSidecarValidator {
1111
/**
1212
* The BIDS sidecar being validated.
1313
* @type {BidsSidecar}
@@ -143,4 +143,4 @@ export class SidecarValidator {
143143
}
144144
}
145145

146-
export default SidecarValidator
146+
export default BidsHedSidecarValidator

bids/validator/tsvValidator.js

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import SidecarValidator from './sidecarValidator'
1+
import BidsHedSidecarValidator from './sidecarValidator'
22
import { BidsHedIssue, BidsIssue } from '../types/issues'
33
import { BidsTsvEvent, BidsTsvRow } from '../types/tsv'
44
import { parseHedString } from '../../parser/parser'
@@ -12,7 +12,7 @@ import { validateHedString } from '../../validator/event/init'
1212
/**
1313
* Validator for HED data in BIDS TSV files.
1414
*/
15-
export class TsvValidator {
15+
export class BidsHedTsvValidator {
1616
/**
1717
* The BIDS TSV file being validated.
1818
* @type {BidsTsvFile}
@@ -55,7 +55,10 @@ export class TsvValidator {
5555
if (BidsIssue.anyAreErrors(parsingIssues)) {
5656
return this.issues
5757
}
58-
const curlyBraceIssues = new SidecarValidator(this.tsvFile.mergedSidecar, this.hedSchemas).validateCurlyBraces()
58+
const curlyBraceIssues = new BidsHedSidecarValidator(
59+
this.tsvFile.mergedSidecar,
60+
this.hedSchemas,
61+
).validateCurlyBraces()
5962
const hedColumnIssues = this._validateHedColumn()
6063
this.issues.push(...curlyBraceIssues, ...hedColumnIssues)
6164
if (BidsIssue.anyAreErrors(this.issues)) {
@@ -383,4 +386,4 @@ export class BidsHedTsvParser {
383386
}
384387
}
385388

386-
export default TsvValidator
389+
export default BidsHedTsvValidator

0 commit comments

Comments
 (0)