You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First, thank you so much for taking the time to create an awesome extension. Diagrams as source code are really nice for manage complexity.
The issue
I'd like to make diagrams as feature-rich as possible in source-code, so I include hyperlinks into them. I create hyperlinks using the extension, but they aren't displayed on Github as clickable hyperlinks.
Screenshot showing hyperlinks viewable in the extension:
However, I feel that if you are working in an organization, then making hyperlinks clickable doesn't increase the security vulnerability. People can always go to the link directly. Making the UI show that a link is clickable in Github is simply an added convenience.
Now that I'm writing this, I'm not sure if this was the right place to ask, since it's more a Github rendering SVGs issue. But wanted to ask here first to see if anyone using this tool has run into this issue.
Thank you, and have a great day!
The text was updated successfully, but these errors were encountered:
Hi there!
First, thank you so much for taking the time to create an awesome extension. Diagrams as source code are really nice for manage complexity.
The issue
I'd like to make diagrams as feature-rich as possible in source-code, so I include hyperlinks into them. I create hyperlinks using the extension, but they aren't displayed on Github as clickable hyperlinks.
The hyperlink not getting rendered on Github preview:
https://github.com/Don-Assamongkol1/hyperlinks-not-rendering-example/blob/main/minimal-example.drawio.svg
But if you view the svg as "raw" and let the browser render it, then hyperlinks get rendered properly. Here, I am assuming that when the browser receives an svg file, that is purely the browser rendering the svg and github is not doing any steps in the middle. https://raw.githubusercontent.com/Don-Assamongkol1/hyperlinks-not-rendering-example/3354b51c9cc9cf82ea48046a9dc109be21b8f543/minimal-example.drawio.svg.
((I'm using Chrome 128.0.6613.138 (Official Build) (arm64)).
I'm wondering, is this a known issue with Github not rendering hyperlinks in SVGs? I've searched through older internet archives and it seems that github displaying svgs was a big deal due to potential security threats.
However, I feel that if you are working in an organization, then making hyperlinks clickable doesn't increase the security vulnerability. People can always go to the link directly. Making the UI show that a link is clickable in Github is simply an added convenience.
Now that I'm writing this, I'm not sure if this was the right place to ask, since it's more a Github rendering SVGs issue. But wanted to ask here first to see if anyone using this tool has run into this issue.
Thank you, and have a great day!
The text was updated successfully, but these errors were encountered: