Skip to content
This repository has been archived by the owner on Jun 23, 2023. It is now read-only.

Report metrics when HandleMessage returns an error #27

Open
tealeg opened this issue Dec 3, 2018 · 0 comments
Open

Report metrics when HandleMessage returns an error #27

tealeg opened this issue Dec 3, 2018 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tealeg
Copy link
Contributor

tealeg commented Dec 3, 2018

Curently we only report metrics when Consumer.handleMessages has called HandleMessage and it has returned a nil error. We need to also report metrics on cases where HandleMessage returns an error, as without this we can get stuck in a loop trying to process a bad message, and nobody would notice.
@tealeg tealeg added enhancement New feature or request good first issue Good for newcomers labels Dec 3, 2018
@asdine asdine added this to the v0.3.0 milestone Jan 9, 2019
@asdine asdine removed this from the v0.3.0 milestone Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tealeg @asdine