Skip to content

Commit fae6c44

Browse files
authored
3.x: Upgrade kafka-clients and okhttp (#7836)
* Upgrade kafka-clients and okhttp * Manage version of okio * Add dependency on okttp3 mockwebserver to align on okhttp3 version
1 parent 3581071 commit fae6c44

File tree

3 files changed

+36
-27
lines changed

3 files changed

+36
-27
lines changed

dependencies/pom.xml

Lines changed: 13 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -99,10 +99,7 @@
9999
<version.lib.jgit>6.7.0.202309050840-r</version.lib.jgit>
100100
<version.lib.jsonp-impl>2.0.1</version.lib.jsonp-impl>
101101
<version.lib.junit>5.7.0</version.lib.junit>
102-
<version.lib.kafka>3.4.0</version.lib.kafka>
103-
<!-- Force upgrade of snappy. This should be removed once kafka-clients is upgraded -->
104-
<!-- See https://issues.apache.org/jira/browse/KAFKA-15498 -->
105-
<version.lib.snappy>1.1.10.5</version.lib.snappy>
102+
<version.lib.kafka>3.6.0</version.lib.kafka>
106103
<version.lib.log4j>2.17.1</version.lib.log4j>
107104
<version.lib.logback>1.2.10</version.lib.logback>
108105
<version.lib.mariadb-java-client>2.6.2</version.lib.mariadb-java-client>
@@ -135,9 +132,10 @@
135132
<version.lib.oci>3.21.0</version.lib.oci>
136133
<version.lib.ojdbc8>21.3.0.0</version.lib.ojdbc8>
137134
<version.lib.database.messaging>19.3.0.0</version.lib.database.messaging>
138-
<version.lib.okhttp3>3.14.9</version.lib.okhttp3>
139-
<!-- Force upgrade to more current version -->
140-
<version.lib.okio>3.4.0</version.lib.okio>
135+
<!-- Manage okio version for dependency convergence -->
136+
<version.lib.okio>3.6.0</version.lib.okio>
137+
<!-- Force upgrade okhttp3 transitive dependency -->
138+
<version.lib.okhttp3>4.12.0</version.lib.okhttp3>
141139
<version.lib.opentelemetry>1.22.0</version.lib.opentelemetry>
142140
<version.lib.opentelemetry.semconv>1.22.0-alpha</version.lib.opentelemetry.semconv>
143141
<version.lib.opentelemetry.opentracing.shim>1.22.0-alpha</version.lib.opentelemetry.opentracing.shim>
@@ -918,13 +916,6 @@
918916
<artifactId>kafka-clients</artifactId>
919917
<version>${version.lib.kafka}</version>
920918
</dependency>
921-
<!-- Force upgrade of snappy. This should be removed once kafka-clients is upgraded -->
922-
<!-- to 3.4.2 or newer. See https://issues.apache.org/jira/browse/KAFKA-15096 -->
923-
<dependency>
924-
<groupId>org.xerial.snappy</groupId>
925-
<artifactId>snappy-java</artifactId>
926-
<version>${version.lib.snappy}</version>
927-
</dependency>
928919
<dependency>
929920
<groupId>org.glassfish.jersey.media</groupId>
930921
<artifactId>jersey-media-json-binding</artifactId>
@@ -1233,24 +1224,11 @@
12331224
</exclusion>
12341225
</exclusions>
12351226
</dependency>
1236-
<!-- 4.x versions cause problems with native-image This is used by jaeger-client -->
12371227
<dependency>
12381228
<groupId>com.squareup.okhttp3</groupId>
12391229
<artifactId>okhttp</artifactId>
12401230
<version>${version.lib.okhttp3}</version>
12411231
</dependency>
1242-
<dependency>
1243-
<!-- required for dependency convergence
1244-
used from both
1245-
com.squareup.okhttp3:mockwebserver:3.13.1
1246-
com.squareup.moshi:moshi:1.8.0
1247-
both referenced by
1248-
io.zipkin.zipkin2:zipkin-junit:2.12.5
1249-
-->
1250-
<groupId>com.squareup.okio</groupId>
1251-
<artifactId>okio</artifactId>
1252-
<version>${version.lib.okio}</version>
1253-
</dependency>
12541232
<!-- END OF Section 3: transitive dependencies we manage the version of for convergence/upgrade -->
12551233

12561234
<!-- Section 4: Testing -->
@@ -1353,6 +1331,14 @@
13531331
<type>pom</type>
13541332
<scope>import</scope>
13551333
</dependency>
1334+
<dependency>
1335+
<!-- For dependency convergence. Used by okhttp -->
1336+
<groupId>com.squareup.okio</groupId>
1337+
<artifactId>okio-bom</artifactId>
1338+
<version>${version.lib.okio}</version>
1339+
<type>pom</type>
1340+
<scope>import</scope>
1341+
</dependency>
13561342
<dependency>
13571343
<groupId>io.netty</groupId>
13581344
<artifactId>netty-bom</artifactId>

grpc/server/pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,12 @@
7979
<artifactId>parsson</artifactId>
8080
<scope>test</scope>
8181
</dependency>
82+
<dependency>
83+
<groupId>com.squareup.okhttp3</groupId>
84+
<artifactId>mockwebserver</artifactId>
85+
<version>${version.lib.okhttp3}</version>
86+
<scope>test</scope>
87+
</dependency>
8288
<dependency>
8389
<groupId>org.mockito</groupId>
8490
<artifactId>mockito-core</artifactId>

tracing/jaeger/pom.xml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,26 @@
4141
<groupId>io.opentelemetry</groupId>
4242
<artifactId>opentelemetry-sdk</artifactId>
4343
</dependency>
44+
<!-- For dependency convergence of kotlin-stdlib -->
45+
<dependency>
46+
<groupId>com.squareup.okio</groupId>
47+
<artifactId>okio</artifactId>
48+
</dependency>
4449
<dependency>
4550
<groupId>io.opentelemetry</groupId>
4651
<artifactId>opentelemetry-exporter-jaeger</artifactId>
52+
<exclusions>
53+
<!-- For dependency convergence. This excludes the transitive dep
54+
on kotlin from okhttp. We defer to the transitive dep from okio -->
55+
<exclusion>
56+
<groupId>org.jetbrains.kotlin</groupId>
57+
<artifactId>kotlin-stdlib-jdk8</artifactId>
58+
</exclusion>
59+
<exclusion>
60+
<groupId>org.jetbrains.kotlin</groupId>
61+
<artifactId>kotlin-stdlib</artifactId>
62+
</exclusion>
63+
</exclusions>
4764
</dependency>
4865
<dependency>
4966
<groupId>io.helidon.tracing</groupId>

0 commit comments

Comments
 (0)