Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability for helidon server to handle ProxyProtocol #7672

Closed
andimullaraj opened this issue Sep 26, 2023 · 3 comments · Fixed by #7829
Closed

Ability for helidon server to handle ProxyProtocol #7672

andimullaraj opened this issue Sep 26, 2023 · 3 comments · Fixed by #7829
Assignees
Labels
4.x Version 4.x enhancement New feature or request P3 TOCI
Milestone

Comments

@andimullaraj
Copy link

The Helidon server seems to provide support for assessing the type of connection based on incoming bytes. Based on that, it looks like the developers can potentially implement a ProxyProtocol handler which will consume in plain connection the first proxy-protocol bytes, then upgrade the connection to SSL. I am suggesting this implementation/handler be available in Helidon server.

In particular:

  • I am not suggesting that the Helidon server infer if proxy-protocol bytes are received and optionally consume them. Instead, the setting is static for a certain server-port and the bytes should always be there.
  • Support for proxy-protocol v1 and v2
  • The fetched values should be made available via the connection properties
@trentjeff trentjeff added this to the 4.x milestone Sep 26, 2023
@trentjeff trentjeff added enhancement New feature or request 4.x Version 4.x labels Sep 26, 2023
@m0mus m0mus added the P3 label Sep 27, 2023
@barchetta
Copy link
Member

See also #7458

@trentjeff
Copy link
Member

@spericas
Copy link
Member

spericas commented Oct 19, 2023

@andimullaraj Implementation is under review here #7829

@barchetta barchetta modified the milestones: 4.x, 4.0.1 Oct 24, 2023
@barchetta barchetta linked a pull request Nov 13, 2023 that will close this issue
@trentjeff trentjeff added the TOCI label Nov 13, 2023
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x enhancement New feature or request P3 TOCI
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants