Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: docs: tables are messed up after upgrade to build-tools 4.0.15 #9676

Closed
barchetta opened this issue Jan 23, 2025 · 3 comments · Fixed by helidon-io/helidon-build-tools#1102
Assignees
Milestone

Comments

@barchetta
Copy link
Member

Tables are no longer rendering correctly after the upgrade to build-tools 4.0.15 (PR #9635).

To reproduce:

cd docs
mvn package
mvn sitegen:serve

In browser go to:

http://localhost:8080/config/io_helidon_webserver_WebServer:

and you'll see a poorly rendered table (it is one giant row). To see what it is supposed to look like go to:

https://helidon.io/docs/4.1.6/config/io_helidon_webserver_WebServer

Change root pom.xml to use:

<version.plugin.helidon-build-tools>4.0.14</version.plugin.helidon-build-tools>

then the table renders correctly.

@barchetta
Copy link
Member Author

Possible side effect of helidon-io/helidon-build-tools#1097

@m0mus m0mus added the triage label Jan 23, 2025
@m0mus m0mus moved this from Triage to Sprint Scope in Backlog Jan 23, 2025
@tjquinno
Copy link
Member

I've rebuilt main locally and I the locally-rendered page looks the same as the published 4.1.6 one.

I'm using Safari 18.1.1.

@barchetta
Copy link
Member Author

After talking to Tim it looks like:

  • Safari renders AOK
  • Firefox 134.0.1 and Chrome 132.0.6834.110 do not render OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed
3 participants