Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider basing on newest version #14

Open
probonopd opened this issue Sep 6, 2020 · 3 comments
Open

Consider basing on newest version #14

probonopd opened this issue Sep 6, 2020 · 3 comments

Comments

@probonopd
Copy link
Member

probonopd commented Sep 6, 2020

That doesn't seem to depend on libfm anymore!

But it is split across 2 git repositories, and needs lxqt-build-tools. Argh!

(Please do not start working on this without prior discussions on the pros and cons, and a potential CI workflow.)

@kettle-7
Copy link

Wait, I just realised that this is related to #53. One way or another, the only way to change the delete/copy/rename code is by changing the original lxde libfm, which the version of libfm-qt we're using depends on for exactly that reason.

Or not, you can assume nothing with PCMan.

@probonopd
Copy link
Member Author

My plan would be to get rid of libfm over time (each time we touch code that uses parts of libfm, replace that code with native Qt code).

Is that a sensible approach?

@kettle-7
Copy link

Yes, then we can do away with GLib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants