From 6500b4ce95cb864424149c275221a34b31e0a478 Mon Sep 17 00:00:00 2001 From: Niclas Norin Date: Tue, 5 Sep 2023 11:48:22 +0200 Subject: [PATCH] Fix: Script error notices --- source/php/Module/Script/Script.php | 18 ++++++++++-------- source/php/Module/Script/views/card.blade.php | 15 ++++++++------- 2 files changed, 18 insertions(+), 15 deletions(-) diff --git a/source/php/Module/Script/Script.php b/source/php/Module/Script/Script.php index 23527879e..4167afdce 100644 --- a/source/php/Module/Script/Script.php +++ b/source/php/Module/Script/Script.php @@ -93,14 +93,16 @@ public function data() : array $data['scriptWrapWithClassName'] = get_field('script_wrap_with', $this->ID) ?? 'card'; $placeholder = get_field('embedded_placeholder_image', $this->ID); - $attachment = wp_get_attachment_image_src($placeholder['ID'], [1000, false]); - - $data['placeholder'] = [ - 'url' => $attachment[0], - 'width' => $attachment[1], - 'height' => $attachment[2], - 'alt' => $placeholder['alt'] - ]; + $attachment = !empty($placeholder) ? + wp_get_attachment_image_src($placeholder['ID'], [1000, false]) : false; + if (!empty($attachment)) { + $data['placeholder'] = [ + 'url' => $attachment[0], + 'width' => $attachment[1], + 'height' => $attachment[2], + 'alt' => $placeholder['alt'] + ]; + } $embededCardPadding = get_field('embeded_card_padding', $this->ID); $data['scriptPadding'] = diff --git a/source/php/Module/Script/views/card.blade.php b/source/php/Module/Script/views/card.blade.php index 5635092f2..706e2bc0d 100644 --- a/source/php/Module/Script/views/card.blade.php +++ b/source/php/Module/Script/views/card.blade.php @@ -15,11 +15,12 @@ @endif @include('partials.content') - - @image([ - 'src' => $placeholder['url'], - 'alt' => $placeholder['alt'], - 'classList' => ['box-image', 'u-print-display--inline-block', 'u-display--none'] - ]) - @endimage + @if(!empty($placeholder['url'])) + @image([ + 'src' => $placeholder['url'], + 'alt' => $placeholder['alt'], + 'classList' => ['box-image', 'u-print-display--inline-block', 'u-display--none'] + ]) + @endimage + @endif @endcard