-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: RN 73 compatibility #726
Conversation
@felipecsl thanks a lot for the PR! 💛
|
@henninghall the The unit tests are failing exactly for this reason, you need to add the same flag here https://github.com/henninghall/react-native-date-picker/blob/master/examples/Rn072/android/gradle.properties |
Fix package
There was another issue related to the namespace not matching the |
Updated both. Please keep in mind that this is a breaking change due to the |
@felipecsl I tried the newly released version of RN 0.73 and the package seems to run fine without this fix. Do you know how to reproduce the issue? Added an Rn073 example project in the repo. |
Interesting. this did pop up with a project I was trying to upgrade, but we put the upgrade on hold for now so I'm no longer actively working on it. |
Apparently this change doesn’t seem to be necessary, the reason is that the react native team added a backward compatibility for this, which is great. They still recommend doing this change, but I would like to postpone is as long as possible since it introduces a breaking change and additional work of having to maintain 2 different branches of the package. I put this PR as as draft meanwhile. |
Are your fixes on the latest version? Somehow I'm still getting a (Trying to update to RN 73, using v4.3.5 of this lib) |
These changes have been not merged yet, so I assume no |
@rvera could you please share an example repo where the issue is present? As far as I know RN 0.73 is supported without this PR and an example repo with RN 0.73 with the the picker is provided in the example folder of this repo. |
Is this pull request abandonned ? |
@VelocityPulse please read comment #726 (comment) Can you provide a repo where this is actually an issue? Then we can look into it again. |
Needed for RN 73 - 74... If you want a workaround, need to update your: gradle-wrapper.properties Change gradle version: And prebuild (EXPO): npx expo prebuild --no-install && npx expo run:android |
I'll close this PR until I become aware of situations where the absence of this change is an issue. |
react-native-community/discussions-and-proposals#671