Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: RN 73 compatibility #726

Closed
wants to merge 6 commits into from
Closed

fix: RN 73 compatibility #726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fcefc6d
fix: RN 73 compatibility
felipecsl Nov 16, 2023
13e2237
enable buildConfig
felipecsl Nov 16, 2023
9e24052
remove package attribute
felipecsl Nov 17, 2023
5c1488a
Update build.gradle
felipecsl Dec 3, 2023
91ebecd
Update gradle.properties
felipecsl Dec 3, 2023
ed4ccd5
Merge branch 'master' into master
felipecsl Dec 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ def safeExtGet(prop, fallback) {
}

android {
def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION
if (agpVersion.tokenize('.')[0].toInteger() >= 7) {
namespace "com.henninghall.date_picker"
}
compileSdkVersion safeExtGet('compileSdkVersion', 29)
buildToolsVersion safeExtGet('buildToolsVersion', "25.0.3")

Expand Down Expand Up @@ -72,4 +76,4 @@ if (isNewArchitectureEnabled()) {
libraryName = "RNDatePicker"
codegenJavaPackageName = "com.henninghall.date_picker"
}
}
}
1 change: 1 addition & 0 deletions android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
android.defaults.buildfeatures.buildconfig=true
2 changes: 1 addition & 1 deletion android/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="com.henninghall.date_picker">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

</manifest>
1 change: 1 addition & 0 deletions examples/Rn072/android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ reactNativeArchitectures=armeabi-v7a,arm64-v8a,x86,x86_64
# are providing them.
newArchEnabled=false

android.defaults.buildfeatures.buildconfig=true
# Use this property to enable or disable the Hermes JS engine.
# If set to false, you will be using JSC instead.
hermesEnabled=true