Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prop contentFont for android #730

Conversation

dumihi313
Copy link

@dumihi313 dumihi313 commented Nov 30, 2023

I added contentFont for custom typeface in content text.
It just work for android

@dumihi313 dumihi313 force-pushed the feat/custom_android_fontsize_content_and_color_divider branch from deb15b3 to 0f843d1 Compare November 30, 2023 04:26
@dumihi313 dumihi313 force-pushed the feat/custom_android_fontsize_content_and_color_divider branch from 0f843d1 to b7b3ac4 Compare November 30, 2023 04:33
@dumihi313 dumihi313 changed the title Done add prop contentFont for android Add prop contentFont for android Nov 30, 2023
@henninghall
Copy link
Owner

Thanks for the PR! what do you mean by "content" in this context of "contentFont"?

@dumihi313
Copy link
Author

The end objective is to call super.setContentTextTypeface()

so this 'content' is get from this word setContentTextTypeface(), Does it make sense?

@henninghall
Copy link
Owner

Thanks once again, some questions:

  1. Can you give an example on how to use this?
  2. Should the prop be the name of the font, a path to a font or a font file?
  3. Where should the font file be placed?
  4. Does it support built in fonts and/or custom ones?
  5. Can we support the android native variant?
  6. Can we support iOS?

@dumihi313
Copy link
Author

dumihi313 commented Dec 20, 2023

Thanks once again, some questions:

  1. Can you give an example on how to use this?
    <DatePicker ....... date={date} onDateChange={setDate} contentFont="fonts/NunitoSans-Italic.ttf" />

  2. Should the prop be the name of the font, a path to a font or a font file?
    It should be location path like "fonts/NunitoSans-Italic.ttf"

  3. Where should the font file be placed?
    fonts in assets android

image
  1. Does it support built in fonts and/or custom ones?
    yes, as I show on fonts in assets android

  2. Can we support the android native variant?
    just only for variant ios-clone

6, Can we support iOS?

As I checked, lib use ios native lib so we can not adjust font family, font size as well ...

@henninghall
Copy link
Owner

iOS clone is no longer supported, this feature could still be useful for the nativeAndroid variant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants