You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I hope you're doing well. I wanted to share a proposal for an API change in XTerminal. I believe this change has the potential to enhance the functionality and provide an improved interface.
Proposal Details:
API change: Currently, XTerminal emits the keypress and data events. Both pass the currently input value to the event listeners however they are emitted at different conditions. I suggest that the library fundamentally emits the keypress event so that the keys: Enter, ArrowUp, ArrowDown and Tab can also be consumable. Those keys can't be captured in the current version(v2.0.8). The data and clear events can then be derived from the keypress event thereby ensuring backward compatibility.
Benefits: Programs built on top of XTerminal will be able to capture all keys and implement the necessary logic as per the use case.
I am currently working on this proposed change locally and it will soon be pushed to a dedicated branch in the repository.
I'm excited to hear your thoughts and feedback on this proposal. Please feel free to share your comments, suggestions, or concerns here.
Thank you for your time and collaboration. Your input is highly appreciated.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
Hello Everyone,
I hope you're doing well. I wanted to share a proposal for an API change in
XTerminal
. I believe this change has the potential to enhance the functionality and provide an improved interface.Proposal Details:
XTerminal
emits the keypress and data events. Both pass the currently input value to the event listeners however they are emitted at different conditions. I suggest that the library fundamentally emits the keypress event so that the keys: Enter, ArrowUp, ArrowDown and Tab can also be consumable. Those keys can't be captured in the current version(v2.0.8). The data and clear events can then be derived from the keypress event thereby ensuring backward compatibility.XTerminal
will be able to capture all keys and implement the necessary logic as per the use case.I am currently working on this proposed change locally and it will soon be pushed to a dedicated branch in the repository.
I'm excited to hear your thoughts and feedback on this proposal. Please feel free to share your comments, suggestions, or concerns here.
Thank you for your time and collaboration. Your input is highly appreciated.
Beta Was this translation helpful? Give feedback.
All reactions