Create a new instance of a entity using constructor

[maikmb]

Hello everyone!

Gotu has the FromJson method to create a new instance of an entity, but the constructor is more efficient to initialize a new instance from any input in json like this:

const user = new User({ ...input });

Can this be classified as an improvement?

[dalssoft]

by definition constructors are the 'Initialize function' of a class. so it is a very special one (actually it is the only one)

by going the way you suggested we will use the this special function to initialize a entity in a very specific way

my only question is: is it the only way to initialize a entity? if so, I don't see a problem in monopolies this function for this purpose. the problem is that I think this is not the only way to do it

another point is: who (1) is different from (2) in terms of readability?

(1) const user = new User({ ...input });

(2) const user = new User.fromJSON({ ...input });

(btw, the issue #1 suggests a different name for fromJSON. maybe newFrom?)

so for now I would prefer to leave the constructor free of responsibilities until we have a better understanding of the possibilities

but the constructor is more efficient to initialize a new instance

how so?

[maikmb]

Json objects are the most used today in most implementations. The documentation shows only two methods of creating the .fromJson instance with Object and String.

We can use JSON as a standard in the constructor to simplify the code and use custom methods for other types, such as ** fromXml, fromArray **.

[italojs]

I think use it into constructor is more intuitive because most languages use this UX to create new instances.

I agree with @maikmb that make sense to have "methods for other types, such as fromXml, fromArray ."

[italojs]

I think it's related with issue #1