fix(item): active menu item on child route

Author: gaetan-hexadog

src/Item.php

@@ -34,7 +34,7 @@ class Item implements Arrayable
         'route' => null,
         'title' => '',
         'type' => 'link', // link | divider | header
-        'url' => null,
+        'url' => '#',
     ];
 
     /**
@@ -144,7 +144,7 @@ public function fill($properties): Item
      */
     public function getAttributes($except = null)
     {
-        return $this->htmlAttributes(Arr::except($this->attributes, $except));
+        return $this->htmlAttributes(Arr::except($this->properties['attributes'], $except));
     }
 
     /**
@@ -156,6 +156,7 @@ public function getUrl(): string
             if (is_array($this->route)) {
                 return URL::route(Arr::get($this->route, 0), Arr::get($this->route, 1, []));
             }
+
             if (is_string($this->route)) {
                 return URL::route($this->route);
             }
@@ -169,7 +170,7 @@ public function getUrl(): string
             return URL::to($this->url, [], true);
         }
 
-        return '';
+        return '#';
     }
 
     /**
@@ -194,22 +195,48 @@ public function hasIcon(): bool
      */
     public function isActive()
     {
-        if ($this->route) {
-            if (is_array($this->route)) {
-                return Route::is(Arr::get($this->route, 0));
-            }
-            if (is_string($this->route)) {
-                return Route::is($this->route);
+        // Check if one of the children is active
+        foreach ($this->children() as $child) {
+            if ($child->isActive()) {
+                return true;
             }
         }
 
-        if ($this->url) {
-            return Request::is($this->url);
+        // Custom set active path
+        if ($path = $this->getActiveWhen()) {
+            return Request::is($path);
         }
 
-        return $this->children()->contains(function ($child) {
-            return $child->isActive();
-        }) ?? false;
+        $path = ltrim(str_replace(url('/'), '', $this->getUrl()), '/');
+        return Request::is(
+            $path,
+            $path . '/*'
+        );
+    }
+
+    /**
+     * @param string $path
+     *
+     * @return $this
+     */
+    public function isActiveWhen($path)
+    {
+        // Remove unwanted chars
+        $path = ltrim($path, '/');
+        $path = rtrim($path, '/');
+        $path = rtrim($path, '?');
+
+        $this->activeWhen = $path;
+
+        return $this;
+    }
+
+    /**
+     * @return string
+     */
+    public function getActiveWhen()
+    {
+        return $this->activeWhen;
     }
 
     /**