Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to put keys containing unicode chars #66

Open
foobargeez opened this issue Jan 29, 2019 · 4 comments
Open

unable to put keys containing unicode chars #66

foobargeez opened this issue Jan 29, 2019 · 4 comments

Comments

@foobargeez
Copy link
Contributor

The underlying encode_base64() from MIME::Base64 expects bytes which is breaking when the key contains unicode chars. Can we encode key string using utf-8 along the lines of:

encode_base64(encode('utf-8', $key));

Thanks!

@hexfusion
Copy link
Owner

hexfusion commented Jan 30, 2019 via email

@foobargeez
Copy link
Contributor Author

Makes sense to me have you tried it?

Yeah ... I am doing that currently in my code which works fine. Let me get a PR ready.

@hexfusion
Copy link
Owner

OK while you are there please add some tests, update change log and maybe add an example to POD. Then I can cut a release for you, thanks!

@hexfusion
Copy link
Owner

@foobargeez how are we doing? If you can give me an idea on timeframe for your PR I can make some time to get this done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants