Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to use go-cmp with autogold.Want inline updates if so desired #12

Open
emidoots opened this issue Jan 8, 2021 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@emidoots
Copy link
Member

emidoots commented Jan 8, 2021

Not unreasonable that someone may have a fair amount of go-cmp tests and want to integrate autogold slowly. We could allow this by having autogold.Want(...).Value() return the interface() value it got, and allowing the user to signal if the test needs updating or not. e.g. they call .Value(), pass it to go-cmp, and invoke .Fail() or something like that.

@emidoots emidoots added the v2 label Jan 8, 2021
@emidoots emidoots added help wanted Extra attention is needed and removed v2 labels Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant