Move LineLinter::isLinterSuppressed to SuppressibleTrait::isSuppressedForLine

Author: Atry

src/Linters/LineLinter.hack

@@ -37,7 +37,7 @@ abstract class LineLinter<+Terror as LineLintError> extends SingleRuleLinter {
       }
 
       // We got an error. Let's check the previous line to see if it is marked as ignorable
-      if ($ln - 1 >= 0 && $this->isLinterSuppressed($ln)) {
+      if ($ln - 1 >= 0 && $this->isSuppressedForLine($this->getFile(), $ln)) {
         continue;
       }
 
@@ -47,17 +47,6 @@ abstract class LineLinter<+Terror as LineLintError> extends SingleRuleLinter {
     return $errs;
   }
 
-  /** Check if this linter has been disabled by a comment on the previous line.
-   */
-  private function isLinterSuppressed(int $base1_line_number): bool {
-    $line_marker = $this->getFile()->lintMarkersForLineBasedSuppression();
-    return (
-      $line_marker[$this->getFixmeMarker()][$base1_line_number] ??
-      $line_marker[$this->getIgnoreSingleErrorMarker()][$base1_line_number] ??
-      null
-    ) is nonnull;
-  }
-
   /** Parse a single line of code and attempts to find lint errors */
   abstract public function getLintErrorsForLine(
     string $line,

src/Linters/SuppressibleTrait.hack

@@ -60,4 +60,15 @@ trait SuppressibleTrait {
     );
   }
 
+  /** Check if this linter has been disabled by a comment on the previous line.
+   */
+  public final function isSuppressedForLine(File $file, int $previous_line_number): bool {
+    $line_marker = $file->lintMarkersForLineBasedSuppression();
+    return (
+      $line_marker[$this->getFixmeMarker()][$previous_line_number] ??
+      $line_marker[$this->getIgnoreSingleErrorMarker()][$previous_line_number] ??
+      null
+    ) is nonnull;
+  }
+
 }