Include a branch name (from the input) when generating artifact names #2895
+21
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since we may end up trying to create artifacts with the same names for different branches when running a scheduled workflow
marko-bekhta
force-pushed
the
build/more-unique-artifacts-names
branch
from
d2f67ec to
f4fb4aa
Compare
DavideD
requested changes
Dec 9, 2025
| echo "yearmonth=$(/bin/date -u '+%Y-%m')" >> "$GITHUB_OUTPUT" | ||
| shell: bash | ||
| - name: Sanitize the branch name | ||
| # So that if we end up using the branch name in the artifact name we won't have any unexpected chars in the name |
Member
There was a problem hiding this comment.
Thanks for the change, it makes sense. But I don't think this comment it's that helpful.
Could you mention instead that we use it for distinguishing reports for different branches, and maybe add an example of the conversion. For example, wip/4.2 becomes wip-4.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Davide 🙂 👋🏻
I was looking at the https://github.com/hibernate/hibernate-reactive/actions/runs/20035758488 and noticed that sometimes we could fail to upload the test results on failure (if the same group failed for a different branch already and we've uploaded the report already: https://github.com/hibernate/hibernate-reactive/actions/runs/20035758488/job/57456696049)
so maybe we can jsut append the branch name there and make them more "unique"