Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Duplicated" or split encounters in Kagerou's encounter history. #203

Open
Esoum opened this issue Dec 7, 2024 · 1 comment
Open

"Duplicated" or split encounters in Kagerou's encounter history. #203

Esoum opened this issue Dec 7, 2024 · 1 comment

Comments

@Esoum
Copy link

Esoum commented Dec 7, 2024

I've been encountering a behavior where after combat ends, the overlay appears to update with a finalized parse/duration, but the original "untrimmed" encounter remains in the overlay history (or sometimes it turns into a bunch of splits). After some troubleshooting in the ACT discord, I decided to do a clean reinstall of ACT to reset all settings to default. The only setting I changed is enabling deucalion. Plugins were reinstalled through ACT, and Kagerou was enabled through the overlay plugin.

The problem persisted through a full reset. I tested both ACT's and OverlayPlugin's respective settings for new encounter conditions. I tested with other overlays to see if they also had the same issue, but it seems to only be isolated with Kagerou.

2024-12-06 20_36_29-Kagerou

2024-12-06 20_37_07-Advanced Combat Tracker - Log Idle - Empyreum - Log Time_ 8_32_58 PM (Est  8_37_

@hibiyasleep
Copy link
Owner

hibiyasleep commented Dec 10, 2024

isNewEncounter(encounter) {
let really = (
!this.lastEncounter
|| this.lastEncounter.region !== encounter.CurrentZoneName
|| this.lastEncounter.duration > parseInt(encounter.DURATION)

Kagerou detects new encounter only with this condition… not sure why (and how) this broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants