-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tokenBurnTransaction): Implement TokenBurnTransaction
E2E tests: TCK
#311
Merged
rwalworth
merged 10 commits into
main
from
00306-tck-implement-tests-for-tokenburntransaction
Jan 10, 2025
Merged
feat(tokenBurnTransaction): Implement TokenBurnTransaction
E2E tests: TCK
#311
rwalworth
merged 10 commits into
main
from
00306-tck-implement-tests-for-tokenburntransaction
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
rwalworth
requested review from
0xivanov,
RickyLB,
agadzhalov,
jsync-swirlds,
gsstoykov and
ivaylogarnev-limechain
December 13, 2024 22:37
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
The improvement suggestions outlined in TokenMintTransaction are equally applicable here:
|
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
…action Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
Done! |
ivaylogarnev-limechain
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Tests are passing in Go! 🎉 |
…action Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
rwalworth
deleted the
00306-tck-implement-tests-for-tokenburntransaction
branch
January 10, 2025 20:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements the
TokenBurnTransaction
tests documented indocs/test-specifications/token-service/tokenBurnTransaction.md
.Related issue(s):
#306
Checklist