Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tokenBurnTransaction): Implement TokenBurnTransaction E2E tests: TCK #311

Merged
merged 10 commits into from
Jan 10, 2025

Conversation

rwalworth
Copy link
Contributor

Description:
This PR implements the TokenBurnTransaction tests documented in docs/test-specifications/token-service/tokenBurnTransaction.md.

Related issue(s):
#306

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth rwalworth added the enhancement New feature or request label Dec 13, 2024
@rwalworth rwalworth self-assigned this Dec 13, 2024
@rwalworth rwalworth linked an issue Dec 13, 2024 that may be closed by this pull request
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@ivaylogarnev-limechain
Copy link
Contributor

The improvement suggestions outlined in TokenMintTransaction are equally applicable here:

  1. The helper functions and their associated comments at the beginning of the file before the actual tests.
  2. Consider using a beforeEach block for initializing repeatable variables to avoid redundancy.
  3. Additionally, moving the minting operations (used for comparison in responses) into constants.

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
…action

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Copy link
Contributor Author

The improvement suggestions outlined in TokenMintTransaction are equally applicable here:

  1. The helper functions and their associated comments at the beginning of the file before the actual tests.
  2. Consider using a beforeEach block for initializing repeatable variables to avoid redundancy.
  3. Additionally, moving the minting operations (used for comparison in responses) into constants.

Done!

Copy link
Contributor

@ivaylogarnev-limechain ivaylogarnev-limechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ivaylogarnev-limechain
Copy link
Contributor

Tests are passing in Go! 🎉

…action

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth rwalworth merged commit 0496e18 into main Jan 10, 2025
2 checks passed
@rwalworth rwalworth deleted the 00306-tck-implement-tests-for-tokenburntransaction branch January 10, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TCK: Implement tests for TokenBurnTransaction
2 participants