Skip to content

feat(tokenFeeScheduleUpdateTransaction): Implement tokenFeeScheduleUpdateTransaction E2E tests: TCK #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Jan 8, 2025
Merged

feat(tokenFeeScheduleUpdateTransaction): Implement tokenFeeScheduleUpdateTransaction E2E tests: TCK #268

merged 38 commits into from
Jan 8, 2025

Conversation

ivaylogarnev-limechain
Copy link
Contributor

Description:
This PR implements the TokenFeeScheduleUpdateTransaction tests documented in test-specifications/token-service/tokenFeeScheduleUpdateTransaction.md. Currently some tests are skipped because of a potential bugs in the services code.

Related issue(s):
#248

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

rwalworth and others added 28 commits August 8, 2024 09:45
@rwalworth
feat: add tests up to custom fees
4868341 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
feat: first draft of all tests
6496dff 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
fix: test issues
2abd4ea 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
fix: kyc key doesn't need to sign tokencreate
864c3fc 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
fix: key tests
808ec38 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
fix: creating a token with freezeDefault=true requires a freeze key
a51a3e2 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
fix: get most tests working
b72b95d 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
fix: align tests with specs
386910e 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
feat: add new decimals tests
d0fabaa 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
feat: add additional int tests
5b788f1 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
fix: add new custom fees tests
51e92ef 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
fix: custom fee tests to work
d4b0897 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
fix: incorrectly numbered test
19c8dcf 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
style: fix white space
a7084c1 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
refactor: update test name
2c9ad38 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
refactor: update field names to be correct
7bbfe1a 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
fix: remove redundant test
f5f27cc 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
feat: first draft of fee schedule update tests
aaa9073 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch 'main' into 00248-tck-implement-tests-for-tokenfeeschedu…
d140bfd 
…leupdatetransaction
@rwalworth
fix: tests
7762ec4 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch '00231-tck-implement-json-rpc-method-for-tokencreatetran…
166a7ee 
…saction' into 00248-tck-implement-tests-for-tokenfeescheduleupdatetransaction

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
fix: start fixing tests
7f02653 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
fix: get tests working
e394cb6 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch 'main' into 00248-tck-implement-tests-for-tokenfeeschedu…
f952d7c 
…leupdatetransaction
@rwalworth
fix: all tests
31a3a40 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
fix: uncomment tests
0764d67 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch 'main' into 00248-tck-implement-tests-for-tokenfeeschedu…
708b7ff 
…leupdatetransaction
@ivaylogarnev-limechain
fix: Removed all uint, int64 max + 1 tests. Added some descriptions t…
4c4e578 
…o the skipped tests and fixed the docs

Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
@ivaylogarnev-limechain ivaylogarnev-limechain linked an issue Nov 4, 2024 that may be closed by this pull request
TCK: Implement tests for TokenFeeScheduleUpdateTransaction #248
Closed
@ivaylogarnev-limechain
refactor: Removed rebundant console.log
84622b5 
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
rwalworth
rwalworth reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing in C++

@ivaylogarnev-limechain
fix: Enabled some tests that were being skipped uncorrectly
754bb48 
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
@ivaylogarnev-limechain
fix: Changed the integers in the customFee.md to strings
75d2f46 
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
@rwalworth rwalworth requested a review from RickyLB November 7, 2024 20:34
@ivaylogarnev-limechain ivaylogarnev-limechain force-pushed the 00248-tck-implement-tests-for-tokenfeescheduleupdatetransaction branch from 9ca1c1f to 6c232d1 Compare November 18, 2024 11:08
rwalworth
rwalworth approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all tests passing with C++ server!

@ivaylogarnev-limechain
Merge branch 'main' into 00248-tck-implement-tests-for-tokenfeeschedu…
103dd71 
…leupdatetransaction

Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
@ivaylogarnev-limechain
refactor: TS transition
1c0cd62 
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
@ivaylogarnev-limechain ivaylogarnev-limechain force-pushed the 00248-tck-implement-tests-for-tokenfeescheduleupdatetransaction branch from 2626df3 to 1c0cd62 Compare December 6, 2024 10:08
@ivaylogarnev-limechain
fix: Fixed assessmentMethod prop assinging and eslint configurations …
7b77e58 
…for TS

Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
@ivaylogarnev-limechain
Merge branch '00295-fix-assessmentMethod-property' into 00248-tck-imp…
b70afba 
…lement-tests-for-tokenfeescheduleupdatetransaction

Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
@ivaylogarnev-limechain
fix: Unskipped test which are now fixed
d106748 
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
@ivaylogarnev-limechain ivaylogarnev-limechain force-pushed the 00248-tck-implement-tests-for-tokenfeescheduleupdatetransaction branch from 340d0b6 to d106748 Compare December 16, 2024 15:13
0xivanov
0xivanov approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in Go and Java. LGTM!

@ivaylogarnev-limechain ivaylogarnev-limechain merged commit c85f115 into main Jan 8, 2025
2 checks passed
@ivaylogarnev-limechain ivaylogarnev-limechain deleted the 00248-tck-implement-tests-for-tokenfeescheduleupdatetransaction branch January 8, 2025 14:47
@rwalworth
Copy link
Contributor

Works in Go and Java. LGTM!

Are there issues in the Go and Java repos for this work? I can't seem to find them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsync-swirlds jsync-swirlds jsync-swirlds left review comments

@0xivanov 0xivanov 0xivanov approved these changes

@rwalworth rwalworth rwalworth approved these changes

@agadzhalov agadzhalov Awaiting requested review from agadzhalov

@gsstoykov gsstoykov Awaiting requested review from gsstoykov

@RickyLB RickyLB Awaiting requested review from RickyLB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TCK: Implement tests for TokenFeeScheduleUpdateTransaction
4 participants
@ivaylogarnev-limechain @rwalworth @0xivanov @jsync-swirlds