Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link broken on all the pages #3

Open
abhyudaypratap opened this issue Oct 16, 2017 · 7 comments
Open

Link broken on all the pages #3

abhyudaypratap opened this issue Oct 16, 2017 · 7 comments

Comments

@abhyudaypratap
Copy link

image
You can submit an improvement to this page by visiting GitHub. You will need to fork the website and submit a Pull Request. If you don't want to use a GitHub account, feel free to submit a patch on the mailing list.

@abhyudaypratap
Copy link
Author

image

@mavidser
Copy link
Contributor

I submitted a patch which got merged, but I guess the build system is broken. Not sure who's hosting the website.

@kprovost
Copy link

There are apparently two branches in play. I'm a little confused as to the how and why of that, so I'd prefer to leave merging that to the web-elves.

Once the merge is done I know how to prod the appropriate machine into updating the website.

@abhyudaypratap
Copy link
Author

abhyudaypratap commented Oct 17, 2017

I am not completely sure but, @mavidser I think the website is rendering the template from build branch and you made changes to gh-pages.

@abhyudaypratap
Copy link
Author

https://github.com/hillhacks/hackbeach/blob/build/travel/index.html#L146

Check this out for travel page, and I think correction is needed here

@mavidser
Copy link
Contributor

I see that, but I'm not very comfortable with the idea of keeping a separate build branch at all. Kind of beats the idea of having a public link to the source, when it doesn't get updated automatically. Unless, of course we want to abandon jekyll.

I'd suggest using the same method which is currently serving hillhacks/website. It looks like it builds well enough (Most likely jekyll build, and serving from the generated _site folder).

Anyway, sending a PR for the build branch until that doesn't get implemented.

@captn3m0
Copy link
Member

The reason I created a second branch was to have an easy way to deploy builds for now. (Builds are done on my system, pushed to github, and pulled on the server).

This is a stopgap till I setup automated builds. I'll delete the build branch post that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants