Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adler video cuts off in UV on play #297

Open
benwbrum opened this issue May 10, 2024 · 1 comment
Open

Adler video cuts off in UV on play #297

benwbrum opened this issue May 10, 2024 · 1 comment

Comments

@benwbrum
Copy link
Collaborator

Several of the Stella Adler videos from HRC appear truncated when you try to play them.

Working hypothesis:
The UV div is set to be 350px high. The video itself is 540 pixels high, and when UV attempts to play it, it expands to 540, but the enclosing div does not expand.

Observations:

  • We never include the height and width of video within the manifest when AA creates it. While this passes validation, it's really not semantically correct.
    • To try: add h/w to the manifest canvas to see if that affects UV
  • We recently made changes to UV's CSS to get small audio controls to work. This involved a max height -- did that introduce a regression?
@benwbrum
Copy link
Collaborator Author

This also happens with a different, IA-hosted manifest: https://saamturner.github.io/betweenthelions/between-the-lions-ep-1

The next step is to adjust the height of UV with the IA-created manifest in isolation on codesandbox and bring it to the UV community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant