Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

PDF generation won't output all pages when there is fragments #488

@terra-yi

Description

@terra-yi

Info

  • Operating System: Windows 10
  • Node Version: 12.18.3
  • Browser Name and Version: Chrome 89

Type

  • bug
  • feature request

Expected Behavior

For example when there are total 8 pages and one page has 3 fragments, it should generate total 11 pages.

Actual Behavior

It discards last 3 pages and generates only 8 pages.

How can we reproduce the behavior?

create a presentation with fragments and try to generate pdf

Problematic code

@fusuma/task-pdf/src/index.js has following code to guess the number of total slides which does not count fragments.

const totalSlidesNum = await page.evaluate(
    () => Array.from(document.querySelectorAll('.swiper-slide')).length
  );

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions