-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FT-event file append pulls back events that are not associated with the asset-identifier #358
Comments
Thanks for the time spent on this @timstackblock, I think it's time for us to take on #287. |
Ok I have pushed up my test here #347 (comment) some are blocked by the corresponding bugs I found but I will comment on #287 |
@timstackblock This issue should be fixed currently in the |
sure let me take a look |
I ran the predicate 2 times and I am getting a new error I have pasted in the predicate so you can run it as well and see if you are getting that same error and no data back.
Here is the contract in the explorer you can scroll down to the bottom to see the FT events we want to pull in with chainhooks https://explorer.hiro.so/txid/0x85309088b806ee358b4b2d0298d79c3b3aa17d0826a31622ad8d5cdd4e3e862c?chain=testnet |
It looks like the name of the event your filtering is off. You have the asset id ending in {
"chain": "stacks",
"uuid": "a2b55836-5fbe-441b-9de8-c24c3cda286c",
"name": "FT Event File",
"version": 1,
"networks": {
"testnet": {
"start_block": 26043,
"end_block": 26043,
"expire_after_occurrence": 1,
"if_this": {
"scope": "ft_event",
"asset_identifier": "ST113MYNN52BC76GWP8P9PYFEP7XWJP6S5YFQM4ZE.shitty-coin::shitty-coin",
"actions": ["transfer"]
},
"then_that": {
"file_append": {
"path": "automate/tests/stacks-predicates/ft-event/ft-event-file-result.json"
}
}
}
}
}
|
@timstackblock Let me know if you're able to confirm this and we should be able to close this issue! |
This works we can close this one |
### Description Address hirosystems/chainhook#354 and hirosystems/chainhook#358 #### Breaking change? N/A ### Checklist - [x] All tests pass - [ ] Tests added in this PR (if applicable) --------- Co-authored-by: Ludo Galabru <ludo@hiro.so>
Describe the bug
FT-event file append pulls back events that are not associated with the asset-identifier asset_identifier": "ST113MYNN52BC76GWP8P9PYFEP7XWJP6S5YFQM4ZE.shitty-coin::shitty",
I ran this predicate and only wanted to return ft-events for "ST113MYNN52BC76GWP8P9PYFEP7XWJP6S5YFQM4ZE.shitty-coin::shitty"
Here is the predicate file
I successfully returned records for that asset identifier which is great but the file is very large and there are a lot of records for other FTs that do not match the asset identifier "ST113MYNN52BC76GWP8P9PYFEP7XWJP6S5YFQM4ZE.shitty-coin::shitty"
Here are screen shots this is the GOOD data
Here is the bad data the which is not "ST113MYNN52BC76GWP8P9PYFEP7XWJP6S5YFQM4ZE.shitty-coin::shitty" and is outside of the scope. You will see FT data with asset identifiers for "asset_class_identifier":"ST2QYV0FDQE9FA10Q4W66P9Z03R1DDCDSKJFK095D.miamicoin-token::miamicoin" the filtering seems to be broken.
The text was updated successfully, but these errors were encountered: