Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when making request to bitcoind node are swallowed by chainhook #375

Closed
MicaiahReid opened this issue Aug 9, 2023 · 1 comment
Closed
Labels
good first issue Good for newcomers
Milestone

Comments

@MicaiahReid
Copy link
Contributor

Describe the bug
When running a scan of a bitcoin predicate, if there is any error from the bitcoin node, the user never sees it. They just get this in their logs: WARN unable to retrieve block hash #801220: will retry in a few seconds (attempt #4).

In my specific case, I was getting htis error from the bitcoind node: unable to parse response (RPC error response: RpcError { code: -8, message: "Block height out of range", data: None }). Seeing this error made it easy to see that I was requesting invalid values, but to see this error I had to make custom changes to chainhook.

Adding the error to this log line could help:

"unable to retrieve block hash #{block_height}: will retry in a few seconds (attempt #{errors_count}).",

To Reproduce
Steps to reproduce the behavior:

  1. Make a bitcoin predicate to that has a start/end block that is outside of the local node's range.
  2. Run the predicate
  3. See that there is no RPC error
@github-project-automation github-project-automation bot moved this to 🆕 New in DevTools Aug 9, 2023
@smcclellan smcclellan added this to the Q3-2023 milestone Aug 14, 2023
@smcclellan smcclellan moved this from 🆕 New to 📋 Backlog in DevTools Aug 14, 2023
@smcclellan smcclellan added the good first issue Good for newcomers label Aug 14, 2023
@smcclellan smcclellan modified the milestones: Q3-2023, Q4-2023 Sep 1, 2023
@smcclellan smcclellan modified the milestones: Q3-2023, Q4-2023 Sep 14, 2023
@smcclellan smcclellan modified the milestones: Q4-2023, Q1-2024 Jan 16, 2024
@MicaiahReid
Copy link
Contributor Author

Closed by #503

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in DevTools Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Archived in project
Development

No branches or pull requests

2 participants