Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test against epoch 3.0 #641

Closed
hugocaillard opened this issue Sep 3, 2024 · 2 comments
Closed

test against epoch 3.0 #641

hugocaillard opened this issue Sep 3, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@hugocaillard
Copy link
Contributor

Because the stacks wire format changed with nakamoto, we want to make sure that chainhook can process epoch 3.0 block.

  • chainhook relies on clarinet/components/stacks-codec to process block
    • this component is duplicated (and slightly altered) code from stacks-core
      • in the future we'd like to simply re-use the code from stacks-core, but unlikely top happen before nakamoto
      • it's slightly outdated right now, but is good enough for clarinet
      • it's not straightforward to update (and it's not tested at all)
  • I think we should test chainhook with the current version of stacks-codec on a testnet running in epoch 3.0.
  • if something goes wrong, we'll be able to upgrade the stacks-codec

I could go ahead and just try to update the stacks-codec right now, but considering how sensitive it is, I'd rather do it only to fix something (or make sure I don't actually break anything)

@hugocaillard hugocaillard added the enhancement New feature or request label Sep 3, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in DevTools Sep 3, 2024
@andresgalante andresgalante moved this from 🆕 New to 📋 Backlog in DevTools Sep 3, 2024
@hugocaillard
Copy link
Contributor Author

hugocaillard commented Sep 3, 2024

Note:
The stacks-codec is very rarely updated (except for some recent clippy fixes that have no impact on the code execution).
Although if we want to be sure to know which version is being used, it's possible to specify the commit in the dependencies like so:

# chainhook/Cargo.toml

[patch.crates-io]
stacks-codec = { git = "https://github.com/hirosystems/clarinet.git", rev = "63dfdb2f5ed7013bb0ce29acf02b823e3eb1ffae" }

Or run cargo update stacks-codec to update to the latest version.

In both case, make sure that the cargo.lock is udpated with the right rev

@rafaelcr
Copy link
Collaborator

Tested on a local chainhook install running against stacks-regtest-env on every epoch transition and everything works correctly

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in DevTools Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants