Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: a9f41d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Stencil-related configuration and dependency versions across the packages while migrating styling from SASS to CSS and improving some code practices.
- Changed type for transaction amount from BigInt to bigint.
- Updated dependency versions, ESLint config, and Stencil configuration.
- Modified UI components to use CSS styling and added keys for list items.
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/connect/src/types/transactions.ts | Updated the transaction amount type to use the built-in primitive. |
| packages/connect/src/stories/ConnectPage.tsx | Updated the handleSubmit callback parameter to use an underscore. |
| packages/connect/src/stories/Connect.stories.tsx | Adjusted escaped quote formatting in story content. |
| packages/connect/package.json | Updated dependency versions for stacks libraries and other tools. |
| packages/connect-ui/stencil.config.ts | Migrated SASS configuration to CSS and updated tailwind plugin usage. |
| packages/connect-ui/src/components/modal/readme.md | Revised attribute table to reflect new attribute names. |
| packages/connect-ui/src/components/modal/modal.tsx | Updated styleUrl, fixed text escaping, and added key prop to list items. |
| packages/connect-ui/src/components/modal/modal.scss | Removed SCSS file as it was replaced by modal.css. |
| packages/connect-ui/src/components/modal/modal.css | Added the new CSS file for modal component styling. |
| packages/connect-ui/package.json | Updated dependency versions for Stencil and tailwind related packages. |
| packages/connect-react/src/react/hooks/use-scroll-lock.tsx | Changed Set types to use object instead of {}. |
| packages/connect-react/src/react/hooks/use-connect.ts | Simplified authOptions update logic. |
| package.json | Upgraded various devDependencies and dependency versions. |
| eslint.config.ts | Introduced updated ESLint flat config. |
| .eslintrc.js | Removed legacy ESLint configuration. |
Comments suppressed due to low confidence (2)
packages/connect-ui/src/components/modal/modal.tsx:114
- [nitpick] Consider using a unique identifier for the key prop in the mapped list items instead of using the array index to improve rendering stability.
<li class="flex items-center gap-3 rounded-[10px] border border-[#EFEFF2] p-[14px]"
packages/connect/src/stories/Connect.stories.tsx:132
- [nitpick] Verify that the use of escaped quotes results in the intended display in the UI, ensuring consistency with the design.
This demo combines approvedProviderIds with custom defaultProviders. Only `"Custom
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependencies across the repository, switches from Stencil Sass to CSS, and resolves minor ESLint errors. The changes primarily focus on keeping dependencies current and ensuring linter compliance without introducing functional modifications.
- Updates various dependencies including Stencil, ESLint, Storybook, and Stacks packages
- Migrates from Stencil Sass to CSS configuration and file format
- Fixes ESLint issues by replacing
{}withobjectand improving code style
Reviewed Changes
Copilot reviewed 17 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/connect/src/types/transactions.ts | Changes BigInt to bigint primitive type |
| packages/connect/src/stories/ConnectPage.tsx | Replaces unused parameter {} with _ |
| packages/connect/src/stories/Connect.stories.tsx | Updates quotes in JSX text content |
| packages/connect/package.json | Updates Stacks package dependencies to newer versions |
| packages/connect-ui/stencil.config.ts | Simplifies Stencil config, removes Sass plugin |
| packages/connect-ui/src/components/modal/readme.md | Fixes table formatting in component documentation |
| packages/connect-ui/src/components/modal/modal.tsx | Changes file extension reference and adds React keys |
| packages/connect-ui/src/components/modal/modal.scss | Removes Sass file (deleted) |
| packages/connect-ui/src/components/modal/modal.css | Adds CSS replacement with Tailwind variables |
| packages/connect-ui/package.json | Updates Stencil and related dependencies |
| packages/connect-react/src/react/hooks/use-scroll-lock.tsx | Replaces {} with object type |
| packages/connect-react/src/react/hooks/use-connect.ts | Improves conditional statement formatting |
| package.json | Updates root-level development dependencies |
| eslint.config.ts | Adds new flat ESLint configuration |
| .github/workflows/version.yml | Updates changeset action version |
| .eslintrc.js | Removes legacy ESLint configuration (deleted) |
| .changeset/late-bushes-boil.md | Adds changeset for dependency updates |
Comments suppressed due to low confidence (1)
packages/connect-ui/package.json:20
- The version "^4.1.4" for tailwindcss does not exist. The latest version of tailwindcss is 3.x series. Version 4.x is still in development and not yet released as a stable version.
"tailwindcss": "^4.1.4",
# Conflicts: # package-lock.json # package.json # packages/connect-ui/package.json # packages/connect-ui/src/components/modal/modal.tsx # packages/connect/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{} → object) — All code changes in this PR are for linter happiness