Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for sections (Gitlab flavor) #13

Open
neiser opened this issue Nov 18, 2022 · 2 comments
Open

Support for sections (Gitlab flavor) #13

neiser opened this issue Nov 18, 2022 · 2 comments

Comments

@neiser
Copy link

neiser commented Nov 18, 2022

The Gitlab documentation allows to introduce sections into the CODEOWNERS such as

[README Owners]
README.md @user1 @user2
internal/README.md @user2

That enables Gitlab to show the code ownership within the UI a little bit nicer. Currently, running this tool (version 1.1.1) on such a file leads to the following error:

$ codeowners
line 1: unexpected character '[' at position 1

Would you be willing to allow support for this? Would you accept a PR for that (I haven't looked into the code yet though)

@hmarr
Copy link
Owner

hmarr commented Nov 22, 2022

I'd be open to this, but as long as it's only enabled by passing in a flag (or by detecting the CODEOWNERS file in the .gitlab directory, perhaps). As this package is designed primarily to work with GitHub CODEOWNERS files, I'd rather it defaults to erroring loudly when it encounters invalid syntax.

@oonoo
Copy link

oonoo commented Jan 12, 2023

Just mentioning: came here for the same reason as the author of this issue. I would be also interested in a gitlab compatible solution (supporting/ignoring these sections).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants