deprecate /api/data/jurisdictions/{jurisdiction_id}/case-type and dis… (#1498)

* deprecate /api/data/jurisdictions/{jurisdiction_id}/case-type and disable FTs

* deprecate /api/data/jurisdictions/{jurisdiction_id}/case-type and disable FTs

* deprecate /api/data/jurisdictions/{jurisdiction_id}/case-type and disable FTs

---------

Co-authored-by: dinesh1patel <74076102+dinesh1patel@users.noreply.github.com>

Author: aktaskaan

Jenkinsfile_CNP

@@ -56,7 +56,7 @@ env.CCD_STUB_SERVICE_URI_BASE="ccd-test-stubs-service-aat.aat.platform.hmcts.net
 env.BEFTA_RETRY_MAX_ATTEMPTS = "3"
 env.BEFTA_RETRY_STATUS_CODES = "500,502,503,504"
 env.BEFTA_RETRY_MAX_DELAY = "1000"
-env.BEFTA_RETRY_NON_RETRYABLE_HTTP_METHODS = "POST,PUT"
+env.BEFTA_RETRY_NON_RETRYABLE_HTTP_METHODS = "PUT"
 
 env.DEFAULT_COLLECTION_ASSERTION_MODE="UNORDERED"
 

Jenkinsfile_nightly

@@ -54,7 +54,7 @@ env.CCD_STUB_SERVICE_URI_BASE="ccd-test-stubs-service-aat.service.core-compute-a
 env.BEFTA_RETRY_MAX_ATTEMPTS = "3"
 env.BEFTA_RETRY_STATUS_CODES = "500,502,503,504"
 env.BEFTA_RETRY_MAX_DELAY = "1000"
-env.BEFTA_RETRY_NON_RETRYABLE_HTTP_METHODS = "POST,PUT"
+env.BEFTA_RETRY_NON_RETRYABLE_HTTP_METHODS = "PUT"
 
 env.DEFAULT_COLLECTION_ASSERTION_MODE="UNORDERED"
 

aat/src/aat/resources/features/F-081/F-081.feature

@@ -7,7 +7,7 @@ Background:
     Given an appropriate test context as detailed in the test data source
 
 #-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
-@S-347
+@S-347 @Smoke
 Scenario: must return 200 with List of jurisdictions
 
     Given a user with [an active profile in CCD]

aat/src/aat/resources/features/F-082/F-082.feature

@@ -7,7 +7,7 @@ Background:
     Given an appropriate test context as detailed in the test data source
 
 #-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
-@S-082.1 @Smoke
+@S-082.1 @Smoke @Ignore
 Scenario: must return 200
 
     Given a user with [an active profile in CCD]
@@ -21,7 +21,7 @@ Scenario: must return 200
       And the response has all other details as expected
 
 #-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
-@S-082.2
+@S-082.2 @Ignore
 Scenario: must return 401 when request does not provide valid authentication credentials
 
     Given a user with [an active profile in CCD]

domain/src/main/java/uk/gov/hmcts/ccd/definition/store/domain/service/casetype/CaseTypeServiceImpl.java

@@ -68,6 +68,13 @@ public boolean caseTypeExistsInAnyJurisdiction(String reference, String jurisdic
         return repository.caseTypeExistsInAnyJurisdiction(reference, jurisdictionId) > 0;
     }
 
+    /**
+     * Find by jurisdiction id.
+     *
+     * @deprecated This endpoint is deprecated due to performance issues
+     */
+    @Deprecated(forRemoval = true)
+    @SuppressWarnings("squid:S1133")
     @Transactional
     @Override
     public List<CaseType> findByJurisdictionId(String jurisdictionId) {

repository/src/main/java/uk/gov/hmcts/ccd/definition/store/repository/CaseTypeRepository.java

@@ -18,6 +18,13 @@ public interface CaseTypeRepository extends VersionedDefinitionRepository<CaseTy
     @Query(SELECT_LATEST_CASE_TYPE_ENTITY_FOR_REFERENCE)
     Optional<CaseTypeEntity> findCurrentVersionForReference(@Param("caseTypeReference") String caseTypeReference);
 
+    /**
+     * Find by jurisdiction id.
+     *
+     * @deprecated This endpoint is deprecated due to performance issues
+     */
+    @Deprecated(forRemoval = true)
+    @SuppressWarnings("squid:S1133")
     @Query("select c from CaseTypeEntity c where c.version in (select max(cm.version) from CaseTypeEntity cm "
         + "where cm.reference=c.reference) and c.jurisdiction.reference=:jurisdictionReference")
     List<CaseTypeEntity> findByJurisdictionId(@Param("jurisdictionReference") String jurisdiction);

rest-api/src/main/java/uk/gov/hmcts/ccd/definition/store/rest/endpoint/CaseDefinitionController.java

@@ -105,6 +105,14 @@ public List<RoleAssignment> getRoleToAccessProfiles(
         return roleToAccessProfilesService.findRoleAssignmentsByCaseTypeId(caseTypeId);
     }
 
+    /**
+     * Find by jurisdiction id.
+     *
+     * @deprecated This endpoint is deprecated due to performance issues and is no longer used by any service from the
+     *             data store.
+     */
+    @Deprecated(forRemoval = true)
+    @SuppressWarnings("squid:S1133")
     @GetMapping(value = "/data/jurisdictions/{jurisdiction_id}/case-type",
         produces = {"application/json"})
     @ApiOperation(value = "Get case types",

rest-api/src/test/java/uk/gov/hmcts/ccd/definition/store/rest/endpoint/CaseDefinitionControllerTest.java

@@ -1,6 +1,7 @@
 package uk.gov.hmcts.ccd.definition.store.rest.endpoint;
 
 import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
@@ -66,6 +67,8 @@ private CaseType createCaseType(String caseTypeId, String jurisdictionPostfix) {
         return caseType;
     }
 
+    @Deprecated
+    @Disabled
     @Nested
     @DisplayName("Test the dataJurisdictionsJurisdictionIdCaseTypeGet method")
     class DataJurisdictionsJurisdictionIdCaseTypeGetTests {