Skip to content

Commit ded0d9c

Browse files
Upgrade : versions.reformLogging to 6.0.1 (#489)
* Upgrade : versions.reformLogging to 6.0.1 * Removed lib/applicationinsights-agent-3.4.9.jar * UPDATE applicationinsights-agent-3.4.9.jar * added net.logstash.logback in build.gradle * reverted version of app insight * added net.logstash.logback * added net.logstash.logback * APP_INSIGHTS_AGENT_VERSION=3.2.9 * Added app-insights-connection-string config * Added app-insights-connection-string config * removed commented part
1 parent c859008 commit ded0d9c

File tree

5 files changed

+14
-10
lines changed

5 files changed

+14
-10
lines changed

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ ENV APPLICATION_SIZE_ON_DISK_IN_MB 48
1010
# Optional
1111
ENV JAVA_OPTS ""
1212

13-
COPY lib/applicationinsights-agent-3.4.9.jar lib/AI-Agent.xml /opt/app/
13+
COPY lib/applicationinsights.json /opt/app/
1414
COPY build/libs/$APP /opt/app/
1515

1616
WORKDIR /opt/app

build.gradle

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ apply plugin: 'idea'
2828
def versions = [
2929
lombok : '1.18.22',
3030
pitest : '1.7.3',
31-
reformLogging : '5.1.9',
31+
reformLogging : '6.0.1',
3232
serenity : '2.0.76',
3333
springBoot : '2.7.7',
3434
restAssured : '4.3.3',
@@ -353,8 +353,8 @@ dependencies {
353353
implementation group: 'org.springframework', name: 'spring-webmvc', version: versions.springVersion
354354

355355
implementation "com.github.hmcts.java-logging:logging:${versions.reformLogging}"
356-
implementation "com.github.hmcts.java-logging:logging-appinsights:${versions.reformLogging}"
357-
356+
implementation "com.github.hmcts.java-logging:logging-appinsights:5.1.9"
357+
implementation group: 'net.logstash.logback', name: 'logstash-logback-encoder', version: '7.0.1'
358358
implementation group: 'com.google.guava', name: 'guava', version: '31.0.1-jre'
359359
//Fix for CVE-2021-29425
360360
implementation 'commons-io:commons-io:2.8.0'
@@ -364,9 +364,7 @@ dependencies {
364364
implementation group: 'io.github.openfeign.form', name: 'feign-form-spring', version: '3.8.0'
365365
implementation "io.github.openfeign:feign-httpclient:11.0"
366366
implementation group: 'org.apache.logging.log4j', name: 'log4j-core', version: versions.log4j
367-
implementation "com.github.hmcts.java-logging:logging:${versions.reformLogging}"
368-
implementation "com.github.hmcts.java-logging:logging-appinsights:${versions.reformLogging}"
369-
367+
370368

371369

372370
testImplementation ('com.github.hmcts:rd-commons-lib:v0.0.13'){

charts/rd-judicial-api/values.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ java:
2525
alias: spring.datasource.password
2626
- name: judicial-api-s2s-secret
2727
alias: JUDICIAL_API_S2S_SECRET
28-
- name: ApplicationInsightsInstrumentationKey
29-
alias: azure.application-insights.instrumentation-key
28+
- name: app-insights-connection-string
29+
alias: app-insights-connection-string
3030
- name: LD-SDK-KEY
3131
alias: LD_SDK_KEY

lib/applicationinsights.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"connectionString": "${file:/mnt/secrets/rd/app-insights-connection-string}",
3+
"role": {
4+
"name": "Professional Reference Data API"
5+
}
6+
}

web.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<httpPlatform processPath="%JAVA_HOME%\bin\java.exe"
1010
stdoutLogEnabled="true"
1111
stdoutLogFile="%HOME%\LogFiles\stdout"
12-
arguments="-javaagent:&quot;%HOME%\site\wwwroot\applicationinsights-agent-2.3.1.jar&quot; -Dfile.encoding=UTF-8 -Djava.net.preferIPv4Stack=true -Dserver.port=%HTTP_PLATFORM_PORT% -jar &quot;%HOME%\site\wwwroot\rd-judicial-api.jar&quot;">
12+
arguments="-javaagent:&quot;%HOME%\site\wwwroot\applicationinsights-agent-3.4.9.jar&quot; -Dfile.encoding=UTF-8 -Djava.net.preferIPv4Stack=true -Dserver.port=%HTTP_PLATFORM_PORT% -jar &quot;%HOME%\site\wwwroot\rd-judicial-api.jar&quot;">
1313
</httpPlatform>
1414
</system.webServer>
1515
</configuration>

0 commit comments

Comments
 (0)