Datepicker sometimes (?) crashes if DOB is negative or nonexistent

[cecilia-donnelly]

I don't have a consistent reproduction recipe for this yet, but a couple times when editing a client that has either no date of birth or a future date of birth (an artifact of old test data that had some people born in the future), the datepicker widget has frozen my browser window and, in one case, completely crashed Firefox. The widget froze similarly in Chrome, but refreshing the page made it possible for me to click "back to results."

Unfortunately I don't know why this only sometimes happens. Can someone else try to reproduce this? I'll try to come up with a real recipe if I can make the widget freeze again.

[cecilia-donnelly]

At one point I saw this error in the console: Uncaught RangeError: maximum call stack size exceeded, which led me to this issue. On the refactor-app branch, where I saw this behavior, we initialize the Pikaday widget in setInitialVars(). Maybe I'm calling that function too many times.