Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't handle nulls in DTO #56

Open
cecilia-donnelly opened this issue May 12, 2016 · 0 comments
Open

Don't handle nulls in DTO #56

cecilia-donnelly opened this issue May 12, 2016 · 0 comments

Comments

@cecilia-donnelly
Copy link
Contributor

From my conversation a couple days ago with @slifty, lightly edited:

The null patch [see 81efbe0 and b8d01da] I'm worried might be avoiding an issue and doing something we shouldn't be doing. Basically "null" is a valid value for a lot of these fields, according to HUD, and even if it isn't, the DTO traditionally isn't the place for that kind of logic; the manager is.

Dan might already be on this, but we need to handle #52 a different way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant