Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server returns 500 errors for cases that should be handled more specifically. #62

Open
kfogel opened this issue Jun 19, 2016 · 1 comment
Open

Server returns 500 errors for cases that should be handled more specifically. #62

kfogel opened this issue Jun 19, 2016 · 1 comment

Comments

@kfogel
Copy link
Member

kfogel commented Jun 19, 2016 •
edited
Loading

There are various cases where the server will return code 500 (Internal Server Error) to the client because something threw a generic exception or failed in some other way, when what we really want is to handle that case with a proper exception. I don't have an example of such a case right now, but @slifty can probably think of some.

Note this is not related to issue #44, or at least they're not about the same thing. It might, however, be related to issue #19.
@kfogel
Copy link
Member Author

kfogel commented Jun 23, 2016 •
edited
Loading

Example of this kind of 500 error: If you don't give a Java-valid date format for any date field, we'll just get a 500 error.

But not all of these cases are about validation. Basically, we should never be returning a 500 error; we should always return something better than that.

kfogel added a commit that referenced this issue Jul 1, 2016
@kfogel
Improve exception-catching for Google authn
c1b7db7 
Although not documented to do so [1], GoogleIdToken.parse() will
apparently throw a "java.lang.IllegalArgumentException" [2] if the
token is invalid by inspection -- e.g., if it's not formatted
properly.  This commit adds a catch for that specific exception, and
furthermore adds a generic exception catch as per issue #62.

After this, going to the "/api/v3/healthcheck/authentication" endpoint
with an "Authorization" header with an invalid value will result in
the response "You are not authenticated" being sent back to the
client, instead of a 500 error.

[1] https://google.github.io/google-api-java-client/releases/1.21.0/\
    javadoc/com/google/api/client/googleapis/auth/oauth2/GoogleIdToken.html

[2] http://stackoverflow.com/questions/32489580/\
    googleauthutil-returns-accestoken-tokenverifier-expects-idtoken
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kfogel