Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the LTSV encoder be a separate package or be a part of the original package? #2

Open
hnakamur opened this issue Jan 28, 2017 · 0 comments

Comments

@hnakamur
Copy link
Owner

This package borrows a lot of code from the original package uber-go/zap: Fast, structured, leveled logging in Go..

If the LTSV encoder becomes a part of the original package and common functions are moved to the separate internal package, the code duplication can be avoided.

However the original author may not want to maintain the LTSV encoder which they probably does not use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant